Skip to content

pointer support for rocm7 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilipDeegan merged 1 commit into from
Sep 4, 2026
Merged

pointer support for rocm7 #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion inc/mkn/gpu/rocm/cls.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ struct Pointer {
if (!t) throw std::runtime_error("invalid nullptr");
MKN_GPU_ASSERT(hipPointerGetAttributes(&attributes, t));
}
bool is_host_ptr() const { return type() == hipMemoryTypeHost; }
bool is_host_ptr() const {
return type() == hipMemoryTypeUnregistered || type() == hipMemoryTypeHost;
}
bool is_device_ptr() const {
return type() == hipMemoryTypeDevice || type() == hipMemoryTypeArray;
}
Expand Down
12 changes: 12 additions & 0 deletions res/mkn/hipcc_sys.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@

super: settings

compiler:
mask:
g++: hipcc

file:
- type: cpp:cxx:cc
archiver: ar -cr
compiler: hipcc -std=c++20 -fPIC
linker: hipcc -lamdhip64
Loading