-
Notifications
You must be signed in to change notification settings - Fork 0
feat(b2b_dashboard): distinct-learner needs-attention count per contract #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
daniellefrappier18
wants to merge
2
commits into
main
Choose a base branch
from
daniellef/needs-attention-contract-aggregate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed and fixed in 4e95e64. This was a real bug, not just a theoretical probe.
Reproduced before the fix — two sub-floor contracts (2 learners each) ordered ahead of one visible contract (6 learners),
limit=2, offset=0:So the client got
data: []besidetotal_count: 1, and contract 103 was reachable only by guessingoffset=2. That also breaks whatOrgAnalyticsResponse's docstring instructs clients to do — comparetotal_countagainstlen(data)plusoffset.After the fix:
Implementation follows your suggestion: the gate is written once as
HAVING COUNT(DISTINCT learner_id) >= %sand spliced into both the page and the count, so they can't drift. The floor is bound twice per request — once into the page's HAVING, once forfetch_and_suppress, which still nulls sub-floor secondary counts within a surviving row. Regression test istest_page_and_count_describe_the_same_gated_set.Worth flagging that this is not specific to this endpoint.
build_selectemits no cohort gate whilebuild_countdoes, so all five MV-backed endpoints plus the admin one have the identical mismatch:That one needs a signature change on shared machinery and touches three routers plus
test_column_contract.py, so it's out of scope here and tracked separately astk-build-select-pages-ungated-while-build-count-gat-8e6b21.