Skip to content

fix(deps): update dependency setuptools to v83 [security] - #4086

Open
renovate[bot] wants to merge 1 commit into
masterfrom
renovate/pypi-setuptools-vulnerability
Open

renovate[bot] wants to merge 1 commit into
masterfrom
renovate/pypi-setuptools-vulnerability

Conversation

@renovate

@renovate renovate Bot commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
setuptools (changelog) <=81.0.0 → <=83.0.0 age confidence

setuptools: MANIFEST.in exclusion bypass in sdist via Unicode normalization collision (NFC/NFD) on macOS APFS/HFS+

CVE-2026-59890 / GHSA-h35f-9h28-mq5c

More information

Details

Summary

When building a source distribution (python -m build --sdist / setup.py sdist), setuptools' FileList applies MANIFEST.in directives (exclude, global-exclude, recursive-exclude, prune) by matching a compiled glob against on-disk file names byte-for-byte, with no Unicode normalization. On normalization-preserving filesystems (notably macOS APFS and HFS+), a file written in NFD and a MANIFEST.in rule written in NFC refer to the same file but are byte-distinct, so the exclusion silently fails to match. A file the maintainer intended to exclude is then packed into the .tar.gz and, if published, uploaded to the public, immutable PyPI index.

Details

File names in FileList.files come from os.walk (setuptools/_distutils/filelist.py, _find_all_simple), so on APFS a file written NFD is offered to the matcher in NFD, while the MANIFEST.in pattern carries the author's editor form (typically NFC). The matching path performs no canonicalization:

##### setuptools/command/egg_info.py  (FileList.global_exclude)
def global_exclude(self, pattern):
    match = translate_pattern(os.path.join('**', pattern))   # fnmatch.translate -> regex, no NFC/NFD
    return self._remove_files(match.match)                   # byte-level regex over raw os.walk names

A rule written NFC (café = 63 61 66 c3 a9) does not match an on-disk name written NFD (café = 63 61 66 65 cc 81), even though the filesystem treats the two as one file.

A unicodedata.normalize('NFD', ...) helper exists in setuptools/unicode_utils.py (decompose()), but it is never called in the manifest matching path, so neither the pattern nor the walked path is normalized before matching. The only normalization in this area, EggInfoCommand._manifest_normalize, uses filesys_decode (bytes→str decode only, no NFC/NFD) and runs when writing SOURCES.txt, after matching has already occurred.

Impact

MANIFEST.in exclusions are the documented mechanism maintainers use to keep secrets, local configs, and private fixtures out of the published sdist. A non-ASCII excluded file may be published to the public, immutable PyPI index despite the rule — an irreversible disclosure with no visual cue (NFC and NFD forms render identically). Exposure is filesystem-dependent and most relevant on macOS APFS/HFS+, where many maintainers build and publish. Pure-ASCII rules are unaffected.

Proof of concept

With a project containing MANIFEST.in:

global-include *.txt *.json
global-exclude secret_café.txt    # rule saved NFC

and an on-disk file secret_café.txt written in NFD, python -m build --sdist packs the secret file into the resulting .tar.gz, while an ASCII control file excluded by the same directive is correctly dropped — isolating the bypass to the NFC-pattern vs. NFD-name mismatch. Reproduced on macOS APFS with setuptools 82.0.1.

Remediation

Normalize both the walked path and each MANIFEST.in pattern to a single canonical form before matching, in both setuptools/command/egg_info.py (FileList) and the vendored setuptools/_distutils/filelist.py. For an exclusion list, err toward excluding more, and document that MANIFEST.in matching is normalization-insensitive on macOS.

Credit

Reported by Tomas Illuminati. Coordinated via CERT/CC VINCE VU#604762.

Severity

  • CVSS Score: 6.1 / 10 (Medium)
  • Vector String: CVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:H/I:L/A:N

References

This data is provided by the GitHub Advisory Database (CC-BY 4.0).


setuptools: MANIFEST.in exclusion bypass in sdist via Unicode normalization collision (NFC/NFD) on macOS APFS/HFS+

BIT-setuptools-2026-59890 / CVE-2026-59890 / GHSA-h35f-9h28-mq5c / PYSEC-2026-3447

More information

Details

Summary

When building a source distribution (python -m build --sdist / setup.py sdist), setuptools' FileList applies MANIFEST.in directives (exclude, global-exclude, recursive-exclude, prune) by matching a compiled glob against on-disk file names byte-for-byte, with no Unicode normalization. On normalization-preserving filesystems (notably macOS APFS and HFS+), a file written in NFD and a MANIFEST.in rule written in NFC refer to the same file but are byte-distinct, so the exclusion silently fails to match. A file the maintainer intended to exclude is then packed into the .tar.gz and, if published, uploaded to the public, immutable PyPI index.

Details

File names in FileList.files come from os.walk (setuptools/_distutils/filelist.py, _find_all_simple), so on APFS a file written NFD is offered to the matcher in NFD, while the MANIFEST.in pattern carries the author's editor form (typically NFC). The matching path performs no canonicalization:

##### setuptools/command/egg_info.py  (FileList.global_exclude)
def global_exclude(self, pattern):
    match = translate_pattern(os.path.join('**', pattern))   # fnmatch.translate -> regex, no NFC/NFD
    return self._remove_files(match.match)                   # byte-level regex over raw os.walk names

A rule written NFC (café = 63 61 66 c3 a9) does not match an on-disk name written NFD (café = 63 61 66 65 cc 81), even though the filesystem treats the two as one file.

A unicodedata.normalize('NFD', ...) helper exists in setuptools/unicode_utils.py (decompose()), but it is never called in the manifest matching path, so neither the pattern nor the walked path is normalized before matching. The only normalization in this area, EggInfoCommand._manifest_normalize, uses filesys_decode (bytes→str decode only, no NFC/NFD) and runs when writing SOURCES.txt, after matching has already occurred.

Impact

MANIFEST.in exclusions are the documented mechanism maintainers use to keep secrets, local configs, and private fixtures out of the published sdist. A non-ASCII excluded file may be published to the public, immutable PyPI index despite the rule — an irreversible disclosure with no visual cue (NFC and NFD forms render identically). Exposure is filesystem-dependent and most relevant on macOS APFS/HFS+, where many maintainers build and publish. Pure-ASCII rules are unaffected.

Proof of concept

With a project containing MANIFEST.in:

global-include *.txt *.json
global-exclude secret_café.txt    # rule saved NFC

and an on-disk file secret_café.txt written in NFD, python -m build --sdist packs the secret file into the resulting .tar.gz, while an ASCII control file excluded by the same directive is correctly dropped — isolating the bypass to the NFC-pattern vs. NFD-name mismatch. Reproduced on macOS APFS with setuptools 82.0.1.

Remediation

Normalize both the walked path and each MANIFEST.in pattern to a single canonical form before matching, in both setuptools/command/egg_info.py (FileList) and the vendored setuptools/_distutils/filelist.py. For an exclusion list, err toward excluding more, and document that MANIFEST.in matching is normalization-insensitive on macOS.

Credit

Reported by Tomas Illuminati. Coordinated via CERT/CC VINCE VU#604762.

Severity

  • CVSS Score: 6.1 / 10 (Medium)
  • Vector String: CVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:H/I:L/A:N

References

This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).


BIT-setuptools-2026-59890 / CVE-2026-59890 / GHSA-h35f-9h28-mq5c / PYSEC-2026-3447

More information

Details

setuptools is a package that allows users to download, build, install, upgrade, and uninstall Python packages. Prior to 83.0.0, FileList applied MANIFEST.in exclude, global-exclude, recursive-exclude, and prune directives by matching compiled glob patterns against on-disk file names without Unicode normalization, so on macOS APFS or HFS+ an NFD file name could bypass an NFC exclusion rule and be packed into a source distribution. This issue is fixed in version 83.0.0.

Severity

  • CVSS Score: 6.1 / 10 (Medium)
  • Vector String: CVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:H/I:L/A:N

References

This data is provided by OSV and the PyPI Advisory Database (CC-BY 4.0).


Release Notes

pypa/setuptools (setuptools)

v83.0.0

Compare Source

v82.0.1

Compare Source

v82.0.0

Compare Source


Configuration

📅 Schedule: (in timezone US/Eastern)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch 2 times, most recently from 29dd5ce to 83f4f19 Compare September 7, 2026 11:22
@arslanashraf7 arslanashraf7 self-assigned this Sep 7, 2026
@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch from 83f4f19 to b20bb34 Compare September 7, 2026 11:53
@arslanashraf7

Copy link
Copy Markdown
Contributor

This update can't be safely applied as-is, and blocking it here.

The upgrade breaks CyberSource payments. setuptools removed the pkg_resources module entirely starting in 82.0.0 (confirmed absent from the 82.0.0, 82.0.1, and 83.0.0 wheels; present in 81.0.0). cybersource-rest-client-python==0.0.78 — the latest version published, no newer release exists — imports pkg_resources directly in CyberSource/api_client.py, and itself pins setuptools<=81.0.0 for exactly this reason. That's why pyproject.toml has the existing cap with the comment # capped by cybersource-rest-client-python (needs pkg_resources).

Reproduced locally: forcing setuptools==83.0.0 alongside the SDK gives

ModuleNotFoundError: No module named 'pkg_resources'
  File ".../CyberSource/api_client.py", line 19, in <module>
    import pkg_resources

uv's resolver independently refuses to move past 81.0.0 for the same reason — raising the cap in pyproject.toml/uv.lock (as this PR does) doesn't actually change the resolved/locked version, it's a no-op against the transitive constraint from cybersource-rest-client-python.

The CVE likely doesn't apply to this app anyway. CVE-2026-59890 is a MANIFEST.in exclusion bypass in setup.py sdist / python -m build --sdist, specific to Unicode NFC/NFD filename normalization on macOS APFS/HFS+. It's a risk for package maintainers publishing sdists to PyPI with excluded secret files. mitxpro is a deployed Django application, not a package built as an sdist and published to PyPI — this vulnerability class doesn't appear to be part of its actual attack surface.

Path forward: this stays blocked until CyberSource ships an SDK release that drops the pkg_resources dependency (or we vendor/patch around it), at which point the setuptools cap can be raised safely. Marking as Blocked so it doesn't get merged inadvertently.

@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch 2 times, most recently from bd3e052 to b10836d Compare September 8, 2026 16:40
@renovate renovate Bot changed the title fix(deps): update dependency setuptools to v83 [security] fix(deps): update dependency setuptools to v84 [security] Sep 10, 2026
@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch 2 times, most recently from e1c4d51 to 5ef6674 Compare September 10, 2026 08:56
@renovate renovate Bot changed the title fix(deps): update dependency setuptools to v84 [security] fix(deps): update dependency setuptools to v83 [security] Sep 10, 2026
@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch 11 times, most recently from 2490a6d to e58a87c Compare September 16, 2026 19:42
@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch 6 times, most recently from 088482c to d68986c Compare September 21, 2026 10:36
@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch from d68986c to c100ed0 Compare September 28, 2026 10:22
@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch from c100ed0 to 684df32 Compare September 28, 2026 11:26
@arslanashraf7 arslanashraf7 removed their assignment Sep 28, 2026
@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch 11 times, most recently from c376443 to bf274b0 Compare October 5, 2026 11:48
@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch 2 times, most recently from f0e74ba to efbc626 Compare October 5, 2026 15:27
@renovate renovate Bot changed the title fix(deps): update dependency setuptools to v83 [security] fix(deps): update dependency setuptools to v84 [security] Oct 5, 2026
@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch from efbc626 to 359c1f4 Compare October 5, 2026 16:03
@renovate renovate Bot changed the title fix(deps): update dependency setuptools to v84 [security] fix(deps): update dependency setuptools to v83 [security] Oct 5, 2026
@renovate
renovate Bot force-pushed the renovate/pypi-setuptools-vulnerability branch from 359c1f4 to 02bfe65 Compare October 5, 2026 21:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant