Repository navigation
fix(proof): translate targets before pairing them with proof hashes - #166
Merged
Davidson-Souza merged 1 commit intoOct 7, 2026
Merged
Conversation
`calculate_hashes` builds its node list out of `self.targets`, which are positions in `MAX_FOREST_ROWS` space, and then pairs it with proof positions that are in the forest's own rows. Both spaces agree for targets at row 0, so this stays invisible until a deletion promotes a leaf: from then on that target sorts nowhere near its sibling and verification fails with `MissingSibling`, even though the proof is valid. Use the already-computed `translated` positions instead, which is what the `calculate_hashes_delete` twin does.
csgui
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
calculate_hashesbuilds its node list out ofself.targets, which are positions inMAX_FOREST_ROWSspace, and then pairs it with proof positions that are in the forest's own rows. Both spaces agree for targets at row 0, so this stays invisible until a deletion promotes a leaf: from then on that target sorts nowhere near its sibling and verification fails withMissingSibling, even though the proof is valid.Use the already-computed
translatedpositions instead, which is what thecalculate_hashes_deletetwin does.This is a cherry-pick of #152. The author seems unresponsive to a red CI, but I want this before releasing implicit dels.