Add and apply most of `rust-bitcoin`'s lints by luisschwab · Pull Request #140 · mit-dci/rustreexo

luisschwab · 2026-07-08T20:49:31Z

Changelog

- Bump `edition` to 2021 (supported since Rust 1.56.0)
- Pins `cargo-audit` and `zizmor` versions on `Cargo.toml`, such that local and CI use the same versions
- Implement `new_hash_map` and `new_hash_set` for the `std` prelude
- Add and apply all of `rust-bitcoin`'s lints (except for documentation lints, left to a follow-up)
- Add the `#![no_std]` directive such that `cargo-rbmt` will also test on a no-std target
- Bump toolchains and fix `clippy::mut_mut` lint on `Stump::serialize`

luisschwab · 2026-07-08T21:31:40Z

Added the #![no_std] directive so that cargo-rbmt will also test on a no-std target. This way we can drop the test-no-std CI job.

~$ cargo rbmt test

[...]

Tests complete.
Test Summary
Commit: de8c93a0b0bdd4864cb512bd5344a81a925cf2a2
  Package: rustreexo
    Examples           : stump_modify, stump_modify:std, stump_modify:with-serde, stump_modify:with-serde std, proof_update, proof_update:std, proof_update:with-serde, proof_update:with-serde std, custom_hash, custom_hash:std, custom_hash:with-serde, custom_hash:with-serde std
    Individual features: serde, std, with-serde
    Feature subsets    : [serde, std], [serde, with-serde], [std, with-serde]
+   No-std check       : ran

ref: https://git.rust-bitcoin.org/rust-bitcoin/rust-bitcoin-maintainer-tools/src/branch/master/cargo-rbmt#no_std

luisschwab · 2026-07-28T10:19:18Z

@Davidson-Souza latest reviews are addressed

luisschwab · 2026-08-04T20:33:18Z

ee6851d rebased on main

Davidson-Souza · 2026-08-05T13:17:52Z

Needs rebase again

luisschwab · 2026-08-05T13:29:21Z

e29d1fe rebased on main (again)

luisschwab · 2026-08-05T15:05:14Z

eaf1f5d bumped toolchains and fixed clippy::mut_mut lint on Stump::serialize

Davidson-Souza · 2026-08-07T17:50:03Z

Needs rebase again again

luisschwab · 2026-08-08T19:10:27Z

b0e958b rebased on main (again again)

luisschwab · 2026-08-26T19:33:03Z

b880e2b rebased on main (again again again)

luisschwab · 2026-09-06T17:44:35Z

ping @Davidson-Souza

luisschwab · 2026-09-10T16:48:23Z

5c27c60 rebased on main (again again again again)

Davidson-Souza · 2026-09-10T18:54:01Z


            - name: Run Tests
              run: cargo rbmt test --toolchain ${{ matrix.toolchain }} --lockfile ${{ matrix.lockfile }}
-


Wait, on 2e541cb I see you removing the old way, but where did the rbmt version is implemented?

The #![no_std] on lib.rs will trigger the check.

Davidson-Souza · 2026-09-10T19:11:29Z

+explicit_iter_loop = "warn"
+filter_map_next = "warn"
+flat_map_option = "warn"
+float_cmp = "allow" # Bitcoin floats are typically limited to 8 decimal places and we want them exact.


We don't do float pointing here

I just copy-pasted it from rust-bitcoin

* Bump the Rust edition to 2021 (released on Rust 1.56.0) * Add the `tools` field to `[package.metadata.rbmt]`, such that CI and local `cargo-audit` and Zizmor versions are in sync * Update the Zizmor CI job to set up rbmt's tools * Update the justfile and README

The `default_trait_access` lint complained that we were instantiating a `HashMap` with `HashMap::with_hasher(Default::default())`. I've mirrored the helpers on the `std` prelude such that we may keep the two in sync.

Import the `std` crate, feature gated on the `std` feature, and add the `#![no_std]` attribute such that `cargo-rbmt` also tests the crate in a no-std target (`thumbv7m-none-eabi`).

Add and apply all `rust-bitcoin` lints, except for documentation lints.

* Bump `stable` from 1.96.0 to 1.97.1 * Bump `nightly` from `nightly-2026-06-23` to `nightly-2026-08-04` * Fix the `clippy::mut_mut` lint on `Stump::serialize`

luisschwab · 2026-09-10T23:02:03Z

d2470b7 updated documentation

Davidson-Souza

ACK 56d2320

luisschwab force-pushed the chore/add-rust-bitcoin-lints branch from c2e655d to de8c93a Compare July 8, 2026 20:53

luisschwab force-pushed the chore/add-rust-bitcoin-lints branch from 1bdc74d to 243e3cb Compare July 8, 2026 21:34

luisschwab mentioned this pull request Jul 8, 2026

fix: use correct cargo category #141

Merged

Davidson-Souza requested changes Jul 16, 2026

View reviewed changes

luisschwab force-pushed the chore/add-rust-bitcoin-lints branch from 243e3cb to 425181b Compare July 17, 2026 18:52

luisschwab requested a review from Davidson-Souza July 17, 2026 18:55

luisschwab force-pushed the chore/add-rust-bitcoin-lints branch from 425181b to b3b859c Compare July 27, 2026 09:02

luisschwab force-pushed the chore/add-rust-bitcoin-lints branch from b3b859c to ee6851d Compare August 4, 2026 20:21

luisschwab force-pushed the chore/add-rust-bitcoin-lints branch 2 times, most recently from b9eaf93 to e29d1fe Compare August 5, 2026 13:28

luisschwab force-pushed the chore/add-rust-bitcoin-lints branch from eaf1f5d to b0e958b Compare August 7, 2026 18:18

eastagiletracker mentioned this pull request Aug 18, 2026

fix(proof): verify inclusion proofs for leaves a deletion promoted above row 0 #152

Open

luisschwab force-pushed the chore/add-rust-bitcoin-lints branch from b0e958b to b880e2b Compare August 26, 2026 19:32

luisschwab force-pushed the chore/add-rust-bitcoin-lints branch from b880e2b to a4f6a97 Compare September 10, 2026 16:47

luisschwab force-pushed the chore/add-rust-bitcoin-lints branch from a4f6a97 to 5c27c60 Compare September 10, 2026 17:46

Davidson-Souza reviewed Sep 10, 2026

View reviewed changes

luisschwab added 3 commits September 10, 2026 15:48

feat!: implement new_hash_map and new_hash_set for the std prelude

8a23a20

The `default_trait_access` lint complained that we were instantiating a `HashMap` with `HashMap::with_hasher(Default::default())`. I've mirrored the helpers on the `std` prelude such that we may keep the two in sync.

fix: make cargo-rbmt run #![no_std] tests

9f89d54

Import the `std` crate, feature gated on the `std` feature, and add the `#![no_std]` attribute such that `cargo-rbmt` also tests the crate in a no-std target (`thumbv7m-none-eabi`).

luisschwab added 3 commits September 10, 2026 15:48

chore!: add and apply most of rust-bitcoin's lints

cf1ce52

Add and apply all `rust-bitcoin` lints, except for documentation lints.

chore(ci): move cargo rbmt tools to vendored action

6045cb4

chore(rust): bump toolchains

d2470b7

* Bump `stable` from 1.96.0 to 1.97.1 * Bump `nightly` from `nightly-2026-06-23` to `nightly-2026-08-04` * Fix the `clippy::mut_mut` lint on `Stump::serialize`

luisschwab force-pushed the chore/add-rust-bitcoin-lints branch from 5c27c60 to d2470b7 Compare September 10, 2026 19:48

luisschwab requested a review from Davidson-Souza September 10, 2026 20:07

fix(doc): update Proof::deserialize's max allocated size

56d2320

Davidson-Souza approved these changes Sep 11, 2026

View reviewed changes

Davidson-Souza merged commit a38b985 into mit-dci:main Sep 11, 2026
14 checks passed

luisschwab deleted the chore/add-rust-bitcoin-lints branch September 11, 2026 13:57


		- name: Run Tests
		run: cargo rbmt test --toolchain ${{ matrix.toolchain }} --lockfile ${{ matrix.lockfile }}

Conversation

luisschwab commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Uh oh!

luisschwab commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

luisschwab commented Jul 28, 2026

Uh oh!

luisschwab commented Aug 4, 2026

Uh oh!

Davidson-Souza commented Aug 5, 2026

Uh oh!

luisschwab commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luisschwab commented Aug 5, 2026

Uh oh!

Davidson-Souza commented Aug 7, 2026

Uh oh!

luisschwab commented Aug 8, 2026

Uh oh!

luisschwab commented Aug 26, 2026

Uh oh!

luisschwab commented Sep 6, 2026

Uh oh!

luisschwab commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Davidson-Souza Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

luisschwab Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Davidson-Souza Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

luisschwab Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

luisschwab commented Sep 10, 2026

Uh oh!

Davidson-Souza left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

luisschwab commented Jul 8, 2026 •

edited

Loading

luisschwab commented Jul 8, 2026 •

edited

Loading

luisschwab commented Aug 5, 2026 •

edited

Loading

luisschwab commented Sep 10, 2026 •

edited

Loading