Repository navigation
Delete the batch 2 redundant tests (test audit TA5, #1734) - #1735
Merged
Merged
Conversation
Batch 2 (B2) measured 162 of 200 sampled KEEP tests as mutation-redundant at 81a3074. Each was read against the AGENTS.md test-value question; 31 are kept by reading (named edge cases, recorded sole catchers, ABI and wire rules, allocation, count and ceiling claims, a randomized differential), 131 are deleted. Helpers deleted only after clippy reported them unused; two test files left with no test are deleted. MUTATIONS.md rows and open specs that name a deleted test say so in place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The slowest recent green run of the job took 14:41 against a 15-minute timeout. 22 minutes is 1.5 times that run. Only this job's timeout moves; #1728 stays open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The TA5 spec records the owner approval, the batch 2 method and result (162/200, 81%, Wilson 75-86%), the blind spot and how reading handled it, the per-package counts, the 31 tests kept by reading with their reasons, the deleted helpers and the #1728 timeout change. The per-test list goes to issue comments. The successor spec records two leads TA5 did not fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, add the gap spec Remove the "TA5 deletions" appendices from the MUTATIONS.md files (a list of deleted tests is a ledger row). Each row that named a deleted test now names a remaining same-crate catcher or says "no catcher recorded". Notes in specs and comments stay only where the name would be a stale reference. Add T5S's survivor-gap spec and fill the TA5 spec's "Survivor gaps" section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The verifier found five deleted tests that were the only defenders of their claims. Re-reading the 73 DELETE answers that named siblings only by file kept 28 more where no remaining test, by full name, asserts the same claim. 64 of the 162 are now kept and 98 deleted; every DELETE answer names the remaining test. MUTATIONS rows name a catcher that can see the row's mutant or say none is recorded; the 1340 spec's gate 3 now asks for a new test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
the_low_shelf_fixed_point_reaches_exact_rest reproduces the 10 Hz slope-0.1 shelf that stuck at 6.01e-20 and holds a ceiling (exact rest within REST_BOUND_SAMPLES); the named defender does not reproduce the shelf. Restored with its helpers; MUTATIONS 1328-M1 is as at ad5c7ae. Counts: 97 deleted, 65 kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Root ruling: a list of deleted tests in a tracked file is a ledger row. Git history and the comments on #1731 keep the list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The successor-leads draft held no work, so its lesson moves into the TA5 spec as its last section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test audit phase B, PR 5 (TA5). This is the last PR of the audit. It deletes the tests of the batch 2 sample (200 random KEEP tests) that are redundant both by measurement and on reading.
Closes #1734. Adds the spec for #1733. Refers to #1728 and does not close it.
Summary
#[allow]was added. 2 test files are deleted.test-debug-atimeout goes from 15 to 22 minutes, which is 1.5 times the slowest recent green run (14:41). It still took 14m29s after TA4.record_peak_windowcould be a no-op and the Shrink the peak heap of a live-only commit #1615 heap ceilings would still pass.The test-by-test list with each answer and its catchers is in the comments on #1734.
Finding for any later cut
About 12 random mutants per test overstate redundancy. 81% of the sample measured redundant, but only 49% was safe to delete after reading. B2's pool-wide projection does not stand. The spec's last section states what a reopening brief must check first.
Gates (author, final tree)
cargo test --locked --all-featureson the touched packages: PASS (2,276 tests after the review fold; parametric-eq 122 after the last restore).check-conformance-boundaries.shand the spec lint scripts PASS.-5.2k / +0.3k lines over 88 files.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.