Skip to content

Delete the measured-redundant tests (test audit TA4, #1731) - #1732

Merged
tamashi095 merged 11 commits into
mainfrom
codex/batch-test-policy-3
Oct 20, 2026
Merged

tamashi095 merged 11 commits into
mainfrom
codex/batch-test-policy-3

Conversation

@tamashi095

@tamashi095 tamashi095 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Test audit phase B, PR 4 (TA4). This PR deletes the tests that mutation measurement (batch 1) found redundant, and adds tests for the real gaps among the mutants that no test caught.

Closes #1731. Adds the specs for #1728, #1729 and #1730.

Summary

  • 150 tests deleted (6,905 test-fn lines):
    • 137 MEASURED-REDUNDANT;
    • 8 REDUNDANT-IF-PEER-KEPT (the greedy cover keeps 2 of those rows, plus 2 UNIQUE rows);
    • 5 UNIQUE tests, deleted together with the test-only code they guarded. That code has no product caller: conformance PlanarBlock, compare_f32_to_f64 and verify_bit_exact_repeat; the effect-contract and effect-runtime map_normalized family; lane saved_word.
  • 71 helpers deleted (2,041 lines). Each one went only after the compiler reported it unused, and no #[allow] was added. 4 test files that had no tests left are deleted, and so is host-web's unused lane dev-dependency.
  • Kept or restored: the UNIQUE tests on product code; the THIN, WEAK and NO-COVERAGE tests; the is_dedicated lags #166: dynamic-rack bank members' buffers are not marked dedicated #169 bank-window regression reproducers; the rack constant-activity count claim.
  • The 21 mutants that no test caught:
  • For the owner (recorded in the spec):
    • Mutation testing cannot see allocation, count or ceiling claims. host-core still counts allocations on the render path of the deleted capi automation tests.
    • The browser side of the hostile-FP live gate (Compose live level values inside the canonical floating-point environment #1709) is deleted. The capi side stays.
    • retained_ceilings.rs covered only native builds, which do not ship. The wasm32 ceilings stay in expected.json.

The test-by-test list with each test's catchers is in the comments on #1731.

Gates (author, final tree)

  • All 31 steps of the qualification lint job: PASS.
  • cargo test --locked --all-features over the 30 touched packages: 3,257 passed, 0 failed.
  • A fresh verifier gave READY WITH FIXES. The fixes are folded in, and the re-check gave READY.

-10.7k / +0.9k lines over 120 files.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

tamashi095 and others added 11 commits October 20, 2026 01:41
- gate-expander: a subnormal gain word in a restored state is refused (normal_or_zero).
- session-validator: the report prints each stage label and every message line.
- realtime-policy: a count in an expression macro is refused (Facts::tokens), and a
  bare array::from_fn after a field named std is refused (is_array_from_fn colons).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Gap 1: a pure seam so the fp-environment refusal can be tested.
Gap 2: public functions that only tests call.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…y guarded (TA4)

Batch 1 (base 81a3074) measured these tests redundant, or UNIQUE only on
code that no product path calls: conformance PlanarBlock, compare_f32_to_f64
and verify_bit_exact_repeat; effect-contract and effect-runtime normalized
mapping pairs; lane CanonicalFpEnv::saved_word. Helpers the compiler then
reported unused are deleted too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…(TA4)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er lead; trim gap-2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d the rack count claim; reword catchers and ceilings

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The TA4 spec's per-test catcher list moves to two comments on #1731,
because the full list is longer than a GitHub issue body allows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tamashi095
tamashi095 merged commit ad5c7ae into main Oct 20, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete the tests that mutation measurement found redundant (test audit TA4)

1 participant