Repository navigation
fix(contract): enforce independent milestone time windows - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Give each milestone its own submission and approval windows and enforce the same deadlines on writes and refunds.
Contract
getMilestoneWindowexposes the active deadline and open flag without changing either existing project or milestone tuple.UI
Read the deadline and open flag at the same block as the project and refund quote. The local clock is used for the countdown on current deployments.
Tests
100 local tests passed. Both compiler profiles cover
deadline - 1, the exact cutoff, a late payout that starts a fresh second window, and refunds from the remaining escrow. The wallet tests cover ABI decoding and older deployments without the window getter. Format check and production build passed.Deployment
Deploy this contract version on Sepolia and configure the new address to enforce these rules.