Keep validation at entry points and clarify execution flow - #35
Merged
Merged
Conversation
Co-Authored-By: ことね <kotone@claudecafe.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI input validation was shared outside command handlers, and internal types were inferred from runtime schemas. Commands now own their option schemas and validate inputs directly, while authoring, rendering, and publishing use independent TypeScript types.
The refactor also makes execution flow explicit across capture logic, report generation, Worker routes, website interactions, and maintenance scripts: main operations come first, validation has purpose-named functions, and peer operations have explicit branches. Existing input errors, output formatting, report presentation, credentials, and release behavior are preserved.
src/cli.tsas the only file directly undersrc/; organize implementation under domain directories.src/cli/and separate format schemas from internal types.Validation:
pnpm checkpassed (334 tests; 23 visual tests passed, 1 existing skip),pnpm build:workerpassed, release JavaScript and infrastructure shell syntax checks passed. Browser smoke checks passed for website copy, animation completion, replay, and skip; local report preview returned HTTP 200.Draft for owner review because this repository automatically merges non-draft PRs.