Skip to content
This repository was archived by the owner on Aug 16, 2023. It is now read-only.

Threadpool based HNSW insert - #989

Open
fhaltmayer wants to merge 1 commit into
milvus-io:mainfrom
fhaltmayer:hnsw_threadpool_index
Open

Threadpool based HNSW insert#989
fhaltmayer wants to merge 1 commit into
milvus-io:mainfrom
fhaltmayer:hnsw_threadpool_index

Conversation

@fhaltmayer

@fhaltmayer fhaltmayer commented Jul 12, 2023

Copy link
Copy Markdown

Update the Add() of HNSW to use thread pool instead of using its own omp.

@sre-ci-robot

sre-ci-robot commented Jul 12, 2023

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fhaltmayer
To complete the pull request process, please assign liliu-z after the PR has been reviewed.
You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot

sre-ci-robot commented Jul 12, 2023

Copy link
Copy Markdown

Welcome @fhaltmayer! It looks like this is your first PR to milvus-io/knowhere 🎉

@mergify mergify Bot added needs-dco DCO is missing in this pull request. do-not-merge/missing-related-issue labels Jul 12, 2023
@mergify

mergify Bot commented Jul 12, 2023

Copy link
Copy Markdown

@fhaltmayer Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@fhaltmayer
fhaltmayer force-pushed the hnsw_threadpool_index branch from b9ec896 to 6eb1fb0 Compare July 12, 2023 23:29
@mergify mergify Bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Jul 12, 2023
@fhaltmayer

fhaltmayer commented Jul 12, 2023

Copy link
Copy Markdown
Author

#514

@filip-halt
Threadpool based HNSW insert
b7fc7a8 
Signed-off-by: Filip <filip.haltmayer@gmail.com>
@fhaltmayer
fhaltmayer force-pushed the hnsw_threadpool_index branch from 6eb1fb0 to b7fc7a8 Compare July 13, 2023 03:19
@liliu-z

liliu-z commented Jul 13, 2023

Copy link
Copy Markdown
Member

/assign @cqy123456

@mergify mergify Bot added the ci-passed label Jul 17, 2023
@liliu-z

liliu-z commented Jul 24, 2023

Copy link
Copy Markdown
Member

/kind improvement

@cqy123456

cqy123456 commented Jul 24, 2023

Copy link
Copy Markdown
Collaborator

/lgtm

@cqy123456

cqy123456 commented Jul 25, 2023

Copy link
Copy Markdown
Collaborator

@fhaltmayer Can you compare the hnsw indexing time before and after using the thread pool?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@foxspy foxspy Awaiting requested review from foxspy
@zhengbuqian zhengbuqian Awaiting requested review from zhengbuqian

At least 1 approving review is required to merge this pull request.

Assignees

@cqy123456 cqy123456

Labels

ci-passed dco-passed DCO check passed. kind/improvement lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fhaltmayer @sre-ci-robot @liliu-z @cqy123456 @filip-halt