test: assert schedule, backup-location, must-gather, setup commands in root help#216
test: assert schedule, backup-location, must-gather, setup commands in root help#216Copilot wants to merge 2 commits into
Conversation
|
Hi @Copilot. Thanks for your PR. I'm waiting for a migtools member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Copilot, kaovilai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Why the changes were made
TestCommandArchitecture's "all major commands exist" subtest only assertedbackup,restore,nabsl-request,nonadmin,client, andversionin the root--helpoutput. It omittedschedule,backup-location,must-gather, andsetup, even thoughcmd/root.goregisters all of them. The test therefore provided no coverage against accidental removal of those commands.This mirrors the fix applied to
oadp-1.4in #212 and is the intended basis for cherry-pick tooadp-1.6andoadp-1.5.How to test the changes made
majorCommandsslice inintegration_test.goto include the four missing commands:Run the targeted subtest:
Expected:
ok github.com/migtools/oadp-cli.