Repository navigation
Conversation
The page's Go-matching rounding was a 40-line walk over the float's bits. toFixed already rounds the exact binary value; it differs from strconv.FormatFloat only on an exact tie (away from zero against to even), and a tie is a multiple of 2^-(digits+1), an exact test. Same output on 16 million values, ties included; the new test pins the ties and fails on plain toFixed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
goFixedinweb/src/run.js(from #2) walked the float's bits in BigInt, about 40 lines, to match Go'sstrconv.FormatFloat.toFixedalready rounds the exact binary value. It differs from Go only on an exact tie: away from zero against to even. A tie is a multiple of 2^-(digits+1), which is an exact test. So the function is nowtoFixedplus that one rule.Evidence:
web/test/gofixed.test.mjspins the ties (0.25, 0.75, 2.5, 3.5, -0.25) and near-ties (0.15, 1.45). With plaintoFixedthe tie test fails../scripts/check.shOK,npm test51/51.The change was written by the bloomery AI assistant.
🤖 Generated with Claude Code