Skip to content

review: labels.py says a merged run removed nothing, as it does for a short file list - #791

Open
juliankang4 wants to merge 1 commit into
midagedev:mainfrom
juliankang4:dgx-spark-review-labels-py-says
Open

juliankang4 wants to merge 1 commit into
midagedev:mainfrom
juliankang4:dgx-spark-review-labels-py-says

Conversation

@juliankang4

Copy link
Copy Markdown
Collaborator

리뷰 라벨 도구가 병합된 PR을 처리할 때 아무것도 지우지 않았다는 사실을 출력 줄에 밝히도록 고칩니다.

What and why

tools/review/labels.py already keeps every label on a merged run: it clears remove when kind == "merged". The line it prints for each item mentioned that only for a short file list, so a merged run printed no reason for the missing removals. The note now reads | merged: nothing removed, no card label decided for a merged run, the same way | <n> of <m> files listed: nothing removed, ... reads for a short list. Which labels the tool adds or removes is unchanged.

  • tools/review/labels.py: the reason removal is held (held) is computed once, as the short-list text or merged, and drives both the cleared remove and the printed note.
  • The self-test table gains a column with the reason each case holds removal (None when it does not). It asserts that exactly the held cases print the note, with that reason.

Release notes: internal: the review labeler's output now says why a merged PR had no labels removed.

Code shape

  • No second copy. The held reason has one owner, held in run, used for both the removal and the note. Duplication found or removed: none.
  • Model code holds only architecture facts. No model code is touched.
  • Dead code is gone. Nothing was made unused.
  • No silent failure. No new fallback; a held run now says so instead of printing nothing.
  • Comments state what is true now. The one comment I edited describes the new table columns.
  • No relaxed gate. No band, tolerance or lint moved. The self-test gained an assertion.
  • cargo fmt and cargo clippy: no Rust file is touched, so I did not run them.

Duplication found or removed (path:line): none.

What I ran

python3 tools/review/labels.py --self-test

The self-test passes on this head. With the old condition (if short) restored, the new assertion fails for the merged case.

What I ran into

This does not block the PR.

  • I did not run just contrib-check on this head.
  • No Rust, CUDA or card path changes, so no GPU gate or node run applies.

Hardware

Not applicable: the change is a Python script and its self-test.

AI help

AI 코딩 에이전트가 코드를 작성한 후 설명을 썼고, 테스트를 마쳤습니다. diff 리뷰와 PR 초안 리뷰는 제가 직접 했습니다.

@github-actions github-actions Bot added the tools Tools, recipes, CI and the toolchain: tools/, justfile, .github/, Cargo label Oct 24, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: CLEAN: The merged-run note explains the existing removal hold, and label decisions remain unchanged.

Checked

Duplicates: 0 new functions, types or constants; the hold reason has one owner in run.
Complexity: run reuses one condition for removal and reporting; self_test extends its existing case table.
Silent failure: 0 new sites; held removals now have an explicit reason.
Tests: The self-test passed with temporary label files held in memory. Restoring the old note condition at tools/review/labels.py:262 fails assertion 371. Dropping removal suppression fails assertion 369. A capped merged diff preserves its specific reason and sends no removals.
Gates: No pins moved or cases removed; the existing self-test gains an assertion.
Escape catalog: No patterns matched.

Notes

Dryer and crapper did not run because no Rust files changed.

Not approved: this pull request changes tools/review/labels.py, which changes the bot, CI or the toolchain and needs a person's approval.

🔨 Shingler, bloomery's review bot: approves a clean pull request and requests changes on a must-fix (how it works)

@juliankang4

Copy link
Copy Markdown
Collaborator Author

@midagedev 확인해보시고 문제가 없다면 머지 부탁드립니다!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools Tools, recipes, CI and the toolchain: tools/, justfile, .github/, Cargo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant