Repository navigation
review: labels.py says a merged run removed nothing, as it does for a short file list - #791
juliankang4 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Verdict: CLEAN: The merged-run note explains the existing removal hold, and label decisions remain unchanged.
Checked
Duplicates: 0 new functions, types or constants; the hold reason has one owner in run.
Complexity: run reuses one condition for removal and reporting; self_test extends its existing case table.
Silent failure: 0 new sites; held removals now have an explicit reason.
Tests: The self-test passed with temporary label files held in memory. Restoring the old note condition at tools/review/labels.py:262 fails assertion 371. Dropping removal suppression fails assertion 369. A capped merged diff preserves its specific reason and sends no removals.
Gates: No pins moved or cases removed; the existing self-test gains an assertion.
Escape catalog: No patterns matched.
Notes
Dryer and crapper did not run because no Rust files changed.
Not approved: this pull request changes tools/review/labels.py, which changes the bot, CI or the toolchain and needs a person's approval.
🔨 Shingler, bloomery's review bot: approves a clean pull request and requests changes on a must-fix (how it works)
|
@midagedev 확인해보시고 문제가 없다면 머지 부탁드립니다!! |
리뷰 라벨 도구가 병합된 PR을 처리할 때 아무것도 지우지 않았다는 사실을 출력 줄에 밝히도록 고칩니다.
What and why
tools/review/labels.pyalready keeps every label on a merged run: it clearsremovewhenkind == "merged". The line it prints for each item mentioned that only for a short file list, so a merged run printed no reason for the missing removals. The note now reads| merged: nothing removed, no card label decidedfor a merged run, the same way| <n> of <m> files listed: nothing removed, ...reads for a short list. Which labels the tool adds or removes is unchanged.tools/review/labels.py: the reason removal is held (held) is computed once, as the short-list text ormerged, and drives both the clearedremoveand the printed note.Nonewhen it does not). It asserts that exactly the held cases print the note, with that reason.Release notes: internal: the review labeler's output now says why a merged PR had no labels removed.
Code shape
heldinrun, used for both the removal and the note. Duplication found or removed: none.cargo fmtandcargo clippy: no Rust file is touched, so I did not run them.Duplication found or removed (
path:line): none.What I ran
The self-test passes on this head. With the old condition (
if short) restored, the new assertion fails for the merged case.What I ran into
This does not block the PR.
just contrib-checkon this head.Hardware
Not applicable: the change is a Python script and its self-test.
AI help
AI 코딩 에이전트가 코드를 작성한 후 설명을 썼고, 테스트를 마쳤습니다. diff 리뷰와 PR 초안 리뷰는 제가 직접 했습니다.