Fix QNN E2E evaluation failures - #1247
Open
DingmaomaoBJTU wants to merge 7 commits into
Open
Conversation
Parse wrapped winml build artifact paths so successful builds are not misreported as export failures, and classify QNN backend graph-finalization rejections as unsupported perf skips instead of relying on registry target blacklists. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Temporarily switch HF-style attention configs to eager only while torch.onnx.export runs, then restore the original attention implementation. This keeps transformers 5 exports compatible with QNN by avoiding SDPA mask guard graphs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Move the eager-attention export helper into transformers_compat so transformers 5 export compatibility behavior stays in one module while preserving lazy import behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Treat Windows native access violation exits from winml build as non-fatal only when the completed ONNX artifact can be resolved from the build output. This preserves real build failures while allowing QNN eval jobs to continue after interpreter teardown crashes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QNN E2E started failing after transformers 5 changed CLIP export to produce per-layer SDPA attention mask guard graphs that include
IsNaNandWhere. Those graphs are rejected by the QNN backend during validate/finalize, so this fixes the export regression instead of disabling the affected eval targets.Summary
transformers_compat.pythat temporarily switches HF-style configs exposing_attn_implementationto eager attention duringtorch.onnx.export, then restores the original values afterward.winml buildas non-fatal only when the completed ONNX artifact can be resolved, so post-build teardown crashes do not hide usable artifacts.Validation
winml sysconfirms local QNNExecutionProvider registration for NPU/GPU/CPU.openai/clip-vit-base-patch32QNN GPUfeature-extractionandzero-shot-image-classificationE2E perf passed.google-bert/bert-base-multilingual-casedQNN GPUmasked-lmandfill-maskE2E perf passed.google-bert/bert-base-multilingual-casedQNN NPUfill-maskE2E perf passed for fp16 and w8a16.google/flan-t5-baseQNN GPU E2E perf passed.