Add certificate loading duration telemetry - #334188
Merged
Christof Marti (chrmarti) merged 1 commit intoSep 3, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Christof Marti (chrmarti)
September 3, 2026 07:03
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The timing correctly spans certificate loading and result aggregation, with an appropriate telemetry classification.
Review tier: Balanced
Findings: None
What changed in this PR
Adds certificate-loading duration telemetry to diagnose slow TLS certificate discovery.
Changes:
- Measures the complete certificate-loading operation in milliseconds.
- Adds the duration as a
PerformanceAndHealthmeasurement.
| File | Description |
|---|---|
src/vs/workbench/api/node/proxyResolver.ts |
Records and classifies certificate-loading duration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Christof Marti (chrmarti)
marked this pull request as ready for review
September 3, 2026 07:12
Contributor
Screenshot ChangesBase: Errored (8)Fixtures that failed to render — no screenshot was produced.
|
Giuseppe Cianci (Giuspepe)
approved these changes
Sep 3, 2026
Christof Marti (chrmarti)
deleted the
chrmarti/certificate-load-duration
branch
September 3, 2026 08:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the duration of loading additional TLS certificates to the existing
additionalCertificatestelemetry event.The duration covers the complete
loadAdditionalCertificatesoperation, including loading local or remote system certificates and combining the results. It is recorded in milliseconds as aPerformanceAndHealthmeasurement.Follow-up to #333953 and #333830.
Validation
npm run typecheck-clientnpm run hygiene