Skip to content

[cherry-pick] Fix bad modal clipping#311486

Merged
mjbvz merged 1 commit intomainfrom
cherry-pick/311474
Apr 20, 2026
Merged

[cherry-pick] Fix bad modal clipping#311486
mjbvz merged 1 commit intomainfrom
cherry-pick/311474

Conversation

@vs-code-engineering
Copy link
Copy Markdown
Contributor

Cherry-pick of #311474 from release/1.117.

Fixes #311426

We only want to apply the modal clipping when the editor itself is in the modal. Already fixed this for webview editors

@vs-code-engineering vs-code-engineering bot added the cherry-pick-artifact Auto-generated cherry-pick PR label Apr 20, 2026
@mjbvz mjbvz enabled auto-merge April 20, 2026 20:48
@github-actions
Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: da62f681 Current: a6acf951

Changed (1)

editor/inlineCompletions/other/JumpToHint/Dark
Before After
before after

@mjbvz mjbvz merged commit 8f3523f into main Apr 20, 2026
26 checks passed
@mjbvz mjbvz deleted the cherry-pick/311474 branch April 20, 2026 21:20
@vs-code-engineering vs-code-engineering bot added this to the 1.117.0 milestone Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-artifact Auto-generated cherry-pick PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

toggling notebook global toolbar will make the notebook UI disappear

2 participants