nes: refactor: simplify toInlineSuggestion#311461
Merged
Conversation
ulugbekna
force-pushed
the
ulugbekna/sacred-haddock
branch
from
32c963b to
4c4a822
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors toInlineSuggestion in the Copilot inline-edits VS Code node implementation to simplify the logic for determining when edits can be represented as same-line ghost text, while preserving behavior via updated/expanded tests.
Changes:
- Extracted next-line insertion handling, multi-line prefix stripping, and same-line validation into helper functions.
- Adjusted next-line insertion rewriting to drop a trailing line ending (CRLF-safe) to avoid introducing a blank line.
- Updated and extended unit tests, including additional CRLF and regression coverage.
Show a summary per file
| File | Description |
|---|---|
extensions/copilot/src/extension/inlineEdits/vscode-node/isInlineSuggestion.ts |
Refactors toInlineSuggestion into smaller helpers and adjusts next-line insertion rewriting behavior. |
extensions/copilot/src/extension/inlineEdits/test/vscode-node/isInlineSuggestion.spec.ts |
Updates existing assertions and adds new test cases for trailing newline trimming, CRLF behavior, and a regression scenario. |
Copilot's findings
- Files reviewed: 52/52 changed files
- Comments generated: 1
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
DonJayamanne
previously approved these changes
Apr 20, 2026
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
ulugbekna
force-pushed
the
ulugbekna/sacred-haddock
branch
from
491191f to
2aa8e62
Compare
roblourens
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Copilot copilot@github.com