Skip to content

[bzip2] fix TARGET_RUNTIME_DLLS - #53501

Open
angelmixu wants to merge 2 commits into
microsoft:masterfrom
angelmixu:bzip2_fix_TARGET_RUNTIME_DLLS
Open

[bzip2] fix TARGET_RUNTIME_DLLS#53501
angelmixu wants to merge 2 commits into
microsoft:masterfrom
angelmixu:bzip2_fix_TARGET_RUNTIME_DLLS

Conversation

@angelmixu

Copy link
Copy Markdown
Contributor
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

Hi! I'm migrating my company's dependencies to vcpkg, and we'd appreciate to have a proper TARGET_RUNTIME_DLLS filled with the linked dll's in each target so our CI and tests have the required dependencies.
I hope this fix is good, and later may come more fixes for libraries :D

@angelmixu

Copy link
Copy Markdown
Contributor Author

I don't know why it complains about CRLF line endings, in my editor all files are LF :/

@BillyONeal

Copy link
Copy Markdown
Member

I don't know why it complains about CRLF line endings, in my editor all files are LF :/

It's other files in edited port directories, not the files you edited. I'll submit a PR against yours with a fix. I wish GitHub made getting to the summary page easier:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants