Skip to content

[openfbx] Fix typo in exported CMake namespace - #53495

Merged
Billy O'Neal (BillyONeal) merged 2 commits into
microsoft:masterfrom
JackBoosY:dev/jack/53451
Aug 20, 2026
Merged

[openfbx] Fix typo in exported CMake namespace#53495
Billy O'Neal (BillyONeal) merged 2 commits into
microsoft:masterfrom
JackBoosY:dev/jack/53451

Conversation

@JackBoosY

@JackBoosY Jack·Boos·Yu (JackBoosY) commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

Fixes #53451

@BillyONeal Billy O'Neal (BillyONeal) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

GPT 5.6 Sol notes the following:

A non-blocking, pre-existing devendoring issue remains: src/ofbx.cpp uses #include "libdeflate.h", which selects OpenFBX's source-local bundled src/libdeflate.h from libdeflate 1.18, while vcpkg links libdeflate 1.25. Compiling and linking against different libdeflate versions is contrary to the port's devendoring expectations.

@BillyONeal
Billy O'Neal (BillyONeal) merged commit 4c422c3 into microsoft:master Aug 20, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[openfbx] Fix typo in exported CMake namespace

2 participants