[ecm] update to 6.29.0 - #53473
Draft
toge (toge) wants to merge 4 commits into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Billy O'Neal (BillyONeal)
requested changes
Aug 19, 2026
Billy O'Neal (BillyONeal)
left a comment
Member
There was a problem hiding this comment.
GPT 5.6 Sol reports:
- The current
ports/ecm/vcpkg.jsonand proposedports/ecm/vcpkg.jsonomit the installed content's licenses. The package includes BSD-3-Clause, BSD-2-Clause, CC0-1.0, GPL-2.0-or-later, and MIT content, whileports/ecm/portfile.cmakeinstalls only the BSD-styleCOPYING-CMAKE-SCRIPTS. This should be reconciled with the vcpkg maintainer guide's copyright and licensing requirements.ports/ecm/usageuses CRLF line endings
Would you consider toge#53 ?
Billy O'Neal (BillyONeal)
marked this pull request as draft
August 19, 2026 00:36
[ecm] Add licenses for vendored parts and fix CRLFs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.https://invent.kde.org/frameworks/extra-cmake-modules/-/tags/v6.29.0