[faker-cxx] update to 4.4.1 - #53471
Merged
Billy O'Neal (BillyONeal) merged 7 commits intoAug 20, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Billy O'Neal (BillyONeal)
requested changes
Aug 19, 2026
Billy O'Neal (BillyONeal)
left a comment
Billy O'Neal (BillyONeal)
left a comment
Member
There was a problem hiding this comment.
GPT 5.6 Sol found a few pre-existing issues :
- Vendored Apache-2 content
- Debug pkgconfig customers link with release bits and are thus broken due to removing
debug/lib/pkgconfig - The project declares itself as 4.0.1 rather than 4.4.0, I filed cieslarmichal/faker-cxx#1126
- CMake config versioning is not connected, I filed cieslarmichal/faker-cxx#1127
Would you consider toge#52 ?
Billy O'Neal (BillyONeal)
marked this pull request as draft
August 19, 2026 00:28
|
Fixed in https://github.com/cieslarmichal/faker-cxx/releases/tag/v4.4.1 |
[faker-cxx] Fix version config bindings
Billy O'Neal (BillyONeal)
marked this pull request as ready for review
August 20, 2026 19:49
Billy O'Neal (BillyONeal)
enabled auto-merge (squash)
August 20, 2026 21:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.https://github.com/cieslarmichal/faker-cxx/releases/tag/v4.4.1