[msl] Add new port - #53442
Draft
Mickyas Tesfaye (Alazar42) wants to merge 1 commit into
Draft
Conversation
Billy O'Neal (BillyONeal)
requested changes
Aug 17, 2026
Billy O'Neal (BillyONeal)
left a comment
Member
There was a problem hiding this comment.
- The packaged project is mature and ready for broad sharing with vcpkg users
- Some other reason: Initial release of Melkam Standard Library (MSL) providing header-only C++20 math and data structure primitives.
This isn't really a justification; the repo in question is 1 day old and doesn't meet any of the usual guidelines to be put in vcpkg's default registry as noted in the maintainer guide.
- The packaged project shows strong association with the chosen port name. Check this box if at least one of the following criteria is met:
- The port name follows the 'GitHubOrg-GitHubRepo' form or equivalent
Owner-Projectform (Alazar42/MSL).
"MSL" is not "GitHubOrg-GitHubRepo"; that would be alazar42-msl. In particular, that name is already associated in repology to https://github.com/akb825/ModularShaderLanguage .
Comment on lines
+1
to
+3
| include("${VCPKG_ROOT_DIR}/ports/vcpkg-cmake/vcpkg-port-config.cmake" OPTIONAL) | ||
| include("${VCPKG_ROOT_DIR}/ports/vcpkg-cmake-config/vcpkg-port-config.cmake" OPTIONAL) | ||
|
|
There was a problem hiding this comment.
Suggested change
| include("${VCPKG_ROOT_DIR}/ports/vcpkg-cmake/vcpkg-port-config.cmake" OPTIONAL) | |
| include("${VCPKG_ROOT_DIR}/ports/vcpkg-cmake-config/vcpkg-port-config.cmake" OPTIONAL) |
These functions are made available when you add the dependencies correctly. I don't even think {VCPKG_ROOT_DIR} is a thing and OPTIONAL is hiding that this never does anything.
Billy O'Neal (BillyONeal)
marked this pull request as draft
August 17, 2026 21:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the new port
msl(Melkam Standard Library) version1.0.0.Melkam Standard Library (MSL) is a modern, high-performance, memory-safe, header-only C++20 utility and math library providing core data types (
Array<T>,String,Color,Vector2,Vector3).Checklist
Owner-Projectform (Alazar42/MSL).vcpkg.jsonmatches what upstream says (1.0.0).vcpkg.jsonmatches what upstream says (MIT).LICENSE).https://github.com/Alazar42/MSL/archive/v1.0.0.tar.gz).vcpkg x-add-version msland committing the result.versions/m-/msl.jsonandversions/baseline.json).