[icu] Fix use of fallback install-sh - #53279
Merged
Merged
Conversation
7 tasks
Kai Pastor (dg0yt)
marked this pull request as ready for review
August 8, 2026 07:14
Contributor
Author
Kai Pastor (dg0yt)
marked this pull request as draft
August 8, 2026 13:45
Contributor
Author
|
But does |
Contributor
Author
|
Unfortunately, the 25 year old |
7 tasks
Kai Pastor (dg0yt)
marked this pull request as ready for review
August 10, 2026 18:11
Kai Pastor (dg0yt)
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes ICU fallback install-sh usage for out-of-source builds.
Changes:
- Uses
top_builddirfor fallback installer paths. - Installs pkg-config files individually.
- Bumps ICU’s port version.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
ports/icu/fix-using-install-sh.diff |
Adds fallback installer fixes. |
ports/icu/portfile.cmake |
Applies the new patch. |
ports/icu/vcpkg.json |
Bumps port version. |
versions/baseline.json |
Updates baseline metadata. |
versions/i-/icu.json |
Records the new port version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+11
to
+13
| + @for file in $(ALL_PKGCONFIG_FILES); do \ | ||
| + $(INSTALL_DATA) "$${file}" $(DESTDIR)$(libdir)/pkgconfig/ ; \ | ||
| + done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
icu uses
AC_PROG_INSTALLwhich tries to find a fast binaryinstalland uses a slowinstall-shscript as fallback.When the fallback is used, icu prepends
$(top_srcdir)for (some) in-source builds. But vcpkg builds out-of-source, and the value ofINSTALLis valid only for the toplevel build dir.So this patch prepends
$(top_builddir)instead in order construct a valid path for every possible case.In addition, workaround install-sh not handling multiple files in one invocation.
To verify, rename
/usr/bin/installor similar before installingicu. (E.g. applyafter
vcpkg_extract_source_archive.)Alternative to / closes #52618.
Fixes #51759.
Fixes #50967.
Fixes #48887.
Fixes #48141.
Fixes #46567.