[osgearth] update to 3.8.1 and add feature stb

[Jack·Boos·Yu (JackBoosY)]

• Changes comply with the maintainer guide.
• SHA512s are updated for each updated download.
• The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
• Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
• All patch files in the port are applied and succeed.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Exactly one version is added in each modified versions file.

Fixes #53169

[Jack·Boos·Yu (JackBoosY)]

looks like the new version requires lerc which is not in vcpkg.

[Kai Pastor (dg0yt)]

lerc is in vcpkg.

[Jack·Boos·Yu (JackBoosY)]

Reproducing the build issue.

[Jack·Boos·Yu (JackBoosY)]

"C:\Program Files (x86)\Microsoft Visual Studio\18\BuildTools\VC\Tools\MSVC\14.51.36231\bin\Hostx64\arm64\cl.exe"   /TP -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -Dosgdb_fastdxt_EXPORTS -ID:\b\osgearth\arm64-windows-dbg\build_include -ID:\b\osgearth\src\c35860baa4-62bc573b58.clean\src -ID:\installed\arm64-windows\include /nologo /DWIN32 /D_WINDOWS /utf-8 /GR /EHsc /MP  /MP /MDd /Z7 /Ob0 /Od /RTC1  /bigobj -std:c++17 -MDd /showIncludes /Fosrc\osgEarthDrivers\fastdxt\CMakeFiles\osgdb_fastdxt.dir\intrinsic.cpp.obj /Fdsrc\osgEarthDrivers\fastdxt\CMakeFiles\osgdb_fastdxt.dir\ /FS -c D:\b\osgearth\src\c35860baa4-62bc573b58.clean\src\osgEarthDrivers\fastdxt\intrinsic.cpp
C:\Program Files (x86)\Microsoft Visual Studio\18\BuildTools\VC\Tools\MSVC\14.51.36231\include\immintrin.h(15): fatal error C1189: #error:  This header is specific to X86, X64, ARM64, and ARM64EC targets

_M_ARM64 should be defined but not, no idea why.

-- Performing Test _OPENTHREADS_ATOMIC_USE_GCC_BUILTINS
CMake Error: try_run() invoked in cross-compiling mode, please set the following cache variables appropriately:
   _OPENTHREADS_ATOMIC_USE_GCC_BUILTINS_EXITCODE (advanced)

No idea why this happened.

[Kai Pastor (dg0yt)]

Basically this should just update to 3.8.1, leave supports unchanged, and not add a lerc dependency.

[Jack·Boos·Yu (JackBoosY)]

Basically this should just update to 3.8.1, leave supports unchanged, and not add a lerc dependency.

Same issue if new dependency is not added.

[Kai Pastor (dg0yt)]

Well, expanding the list of supported platforms which were deliberately marked as unsupported in the past is a development task, not a version bump task.

[Jack·Boos·Yu (JackBoosY)]

Well, expanding the list of supported platforms which were deliberately marked as unsupported in the past is a development task, not a version bump task.

I forgot to revert this changes...

[Billy O'Neal (BillyONeal)]

Thanks for the version update!

Some notes from GPT 5.6 Sol:

• The exported osgEarth::osgEarthImGui target publicly links imgui::imgui (patch), but the installed package configuration does not create that target. Consequently, a consumer using only find_package(osgEarth CONFIG REQUIRED) fails during generation.

That is, we need a missing find_dependency somewhere. That is present in 3.8.0 as well so not a must fix to take the update.

• osgEarth 3.8.1 now compiles its bundled stb_image_resize2 implementation through ImageUtils.cpp. Please devendor this implementation, updating the stb port if necessary, or select a non-stb scaler path so bundled third-party code is not built.

This was introduced in pelicanmapping/osgearth#2977 so it's a new vendored thing.

• The installed TinyXML headers contain a Zlib license and copyright notice (tinyxml.h), but the port currently installs only osgEarth's root license (portfile.cmake).

Also an existing problem but it's trivial enough to fix that I think it should be.

Request-changes for the new vendored dependency and the license meadata only.

[Jack·Boos·Yu (JackBoosY)]

• osgEarth 3.8.1 now compiles its bundled stb_image_resize2 implementation through ImageUtils.cpp. Please devendor this implementation, updating the stb port if necessary, or select a non-stb scaler path so bundled third-party code is not built.

This was introduced in pelicanmapping/osgearth#2977 so it's a new vendored thing.

STB is already disabled by default in portfile

• The installed TinyXML headers contain a Zlib license and copyright notice (tinyxml.h), but the port currently installs only osgEarth's root license (portfile.cmake).

Also an existing problem but it's trivial enough to fix that I think it should be.

Request-changes for the new vendored dependency and the license meadata only.

Sadly, osgearth modified tinyxml code so we cannot simply use vcpkg installed tinyxml:
https://github.com/pelicanmapping/osgearth/blob/f4a49c2968bbcf814281ac0836a50ff1d4a31952/src/osgEarth/tinyxml/tinyxml.h#L85-L94

[Billy O'Neal (BillyONeal)]

Sadly, osgearth modified tinyxml code so we cannot simply use vcpkg installed tinyxml:
https://github.com/pelicanmapping/osgearth/blob/f4a49c2968bbcf814281ac0836a50ff1d4a31952/src/osgEarth/tinyxml/tinyxml.h#L85-L94

:( They try to put some things in namespaces but not everything.

[Jack·Boos·Yu (JackBoosY)]

:( They try to put some things in namespaces but not everything.

They also exported the classes:
https://github.com/pelicanmapping/osgearth/blob/f4a49c2968bbcf814281ac0836a50ff1d4a31952/src/osgEarth/tinyxml/tinyxml.h#L205-L207

I think the only thing we can do is keep the embedded tinyxml in osgearth.

[Jack·Boos·Yu (JackBoosY)]

My last comment was lost?

:( They try to put some things in namespaces but not everything.

Sadly they also export the new class and use it in their code:
https://github.com/pelicanmapping/osgearth/blob/f4a49c2968bbcf814281ac0836a50ff1d4a31952/src/osgEarth/tinyxml/tinyxml.h#L136-L138

I think we can only keep using the embedded tinyxml instead of using vcpkg installed tinyxml.

[Jack·Boos·Yu (JackBoosY)]

Oh, looks good, I will try feature stb again.

[Billy O'Neal (BillyONeal)]

I think we can only keep using the embedded tinyxml instead of using vcpkg installed tinyxml.

There's an argument that we should deindex over this but as long as it isn't actively creating problems I'm not going to push too hard to do that.

GPT 5.6 Sol notes:

• The new tinyxml dependency is unused: osgEarth still compiles and installs its modified bundled TinyXML sources.

Would you consider JackBoosY#11 which fixes this part?

• osgEarth 3.8.1 defaults OSGEARTH_USE_STB_IMAGE_RESIZE to 1 and compiles the bundled src/third_party/stb_image_resize2.h into the core library. The new port feature only controls the separate STB DXT plugin through OSGEARTH_ENABLE_STBDXT, so it does not address this vendored implementation.

Should we set OSGEARTH_USE_STB_IMAGE_RESIZE to 0 to avoid tripping over this or try to update our STB to match and devendor?

[Jack·Boos·Yu (JackBoosY)]

Hope it works🙏