[libjpeg-turbo] Patch vcpkg dependencies for 3.2.0 by tartanpaint · Pull Request #52891 · microsoft/vcpkg

tartanpaint · 2026-07-14T10:46:16Z

Changes comply with the maintainer guide.
SHA512s are updated for each updated download.
The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
All patch files in the port are applied and succeed.
The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
Exactly one version is added in each modified versions file.

The port file update will use the zlib and libspng dependencies introduced with libjpeg-turbo 3.2.0 from vcpkg rather than building additional copies of these from the libjpeg-turbo source tree.
The libjpeg-turbo patch files have been generated directly from commits in the upstream project repository and may be removed with a port update to a future version of libjpeg-turbo. Related libjpeg-turbo issue: libjpeg-turbo/libjpeg-turbo#901

Billy O'Neal (BillyONeal) · 2026-07-14T22:12:34Z

The static versions are all likely failing due to this problem GPT 5.6 Sol found:

The PR switches static turbojpeg to external libspng/zlib dependencies, but the installed libturbojpeg.pc still publishes only -lturbojpeg. Because upstream already provides pkg-config metadata, vcpkg review checks that integration when present (review guide). Static pkg-config consumers therefore miss the new dependencies introduced by the port changes (vcpkg.json, portfile.cmake); the upstream template has no Requires.private or Libs.private entry for those libraries (libturbojpeg.pc.in).

Fix: update the packaging/patch so pkg-config --static --libs libturbojpeg emits complete static link metadata for the vcpkg build. Since libspng does not currently provide a pkg-config file in vcpkg, Requires.private: spng alone is not enough unless that integration is added; otherwise use appropriate Libs.private entries for the vcpkg dependency chain and verify a static pkg-config consumer links.

You might also want to fix this other bit it found while you are here but that's not blocking:

The manifest still declares only BSD-3-Clause, while upstream documents IJG licensing for the libjpeg API and inherited code in addition to BSD-3-Clause for TurboJPEG (upstream license). vcpkg expects license metadata to match the installed package and upstream terms (manifest license docs. This mismatch predates the PR.

…-patch

…static-md since MSVC is not supported

…-patch

Kai Pastor (dg0yt) · 2026-08-06T18:56:56Z

+-CMAKE_MINIMUM_REQUIRED(VERSION 2.8.12.1)
+CMAKE_MINIMUM_REQUIRED(VERSION 3.5)


I believe these CMAKE_MINIMUM_REQUIRED changes are not necessary in a vcpkg patch. vcpkg uses CMake > 4 and does set(ENV{CMAKE_POLICY_VERSION_MINIMUM} 3.5)

These CMake changes are part of the upstream PR used to generate the patch file: OpenKinect/libfreenect2#1209

Kai Pastor (dg0yt) · 2026-08-06T18:57:46Z

+
+ IF(LIBFREENECT2_WITH_VT_SUPPORT)
+-  FIND_PACKAGE(TurboJPEG)
+  find_package(libjpeg-turbo CONFIG)


You might do

Suggested change

+ find_package(libjpeg-turbo CONFIG)

+ find_package(TurboJPEG NAMES libjpeg-turbo)

and get the original TurboJPEG_FOUND. And then reduce patching in other spots.

I've regenerated the find_libjpegturbo.patch file to instead modify the cmake_modules/FindTurboJPEG.cmake file, leaving the main CMakeLists.txt file for libfreenect2 unmodified. Hopefully this is acceptable.

Kai Pastor (dg0yt) · 2026-08-06T19:01:45Z

+    find_dependency(PkgConfig)
+    if(PkgConfig_FOUND)
+      pkg_check_modules(spng REQUIRED spng IMPORTED_TARGET)
+    endif()


Using imported targets from pkgconfig is complicated for reverse dependencies with MSVC. In other ports we use the variables (and in particular <Prefix>_LINK_LIBRARIES) to get resolved libs instead.

These patches are generated from upstream libjpeg-turbo commits which will be included in the next libjpeg-turbo release. The patches may therefore be removed from the portfile when an update is available for the next version of libjpeg-turbo.
I've included comments in the portfile referencing the upstream commits used for the patch files.

That's not true in general. If we see something bogus we can fix bogus and submit the fix for bogus upstream. I agree with Kai Pastor (@dg0yt) and think this is incorrect. Zlib has conventions for how it is found in CMake, and libspng publishes CMake configs: https://github.com/randy408/libspng/blob/adc94393dbeddf9e027d1b2dfff7c1bab975224e/CMakeLists.txt#L65-L81

We should stay entirely in the CMake configs namespace if at all possible and it appears possible here.

Oh, I see, this is confusing because it's patches on patches. Kai Pastor (@dg0yt) I think your comment is resolved by 0002+0003 in this series.

Kai Pastor (dg0yt) · 2026-08-06T19:02:53Z

+    if(PkgConfig_FOUND)
+      pkg_check_modules(spng REQUIRED spng IMPORTED_TARGET)
+    endif()
+  else()


Did you mean

Suggested change

+ else()

+ endif()

+ if(WITH_SYSTEM_ZLIB)

(one extra line)

This also is from the upstream libjpeg-turbo commits used to generate the patch file. The intention would be that these patches can be removed in a future release while maintining the same functionality. The specific commits used for the libjpeg-turbo patches are now listed in comments in the portfile.

…-patch

…nan conan-io/conan-center-index#7628

…sses

…patches

…-patch

Billy O'Neal (BillyONeal)

The pkgconfig fix for libspng is not quite right because they make libspng_static.pc for static targets. I'm trying to prepare a fix for upstream. But for now posting this stuff about the freenect2 changes because that's separable.

Billy O'Neal (BillyONeal) · 2026-08-20T21:17:44Z

+# force use of OpenCL 1.2
+#string(APPEND VCPKG_CXX_FLAGS " -DCL_TARGET_OPENCL_VERSION=120")
+#string(APPEND VCPKG_C_FLAGS " -DCL_TARGET_OPENCL_VERSION=120")
+


We should not check in commented out code unless we are documenting specific instructions on how one is to create an overlay. Also given the changes to vcpkg_cmake_configure below it seems likely that these are wrong.

Also GPT 5.6 Sol observes that both of these are dead / disconnected.

Billy O'Neal (BillyONeal) · 2026-08-20T21:18:34Z

+    find_dependency(PkgConfig)
+    if(PkgConfig_FOUND)
+      pkg_check_modules(spng REQUIRED spng IMPORTED_TARGET)
+    endif()


That's not true in general. If we see something bogus we can fix bogus and submit the fix for bogus upstream. I agree with Kai Pastor (@dg0yt) and think this is incorrect. Zlib has conventions for how it is found in CMake, and libspng publishes CMake configs: https://github.com/randy408/libspng/blob/adc94393dbeddf9e027d1b2dfff7c1bab975224e/CMakeLists.txt#L65-L81

We should stay entirely in the CMake configs namespace if at all possible and it appears possible here.

Billy O'Neal (BillyONeal) · 2026-08-20T23:16:55Z

-  "port-version": 2,
+  "port-version": 3,
  "description": "Open source drivers for the Kinect for Windows v2 device",
  "homepage": "https://github.com/OpenKinect/libfreenect2",


This repo appears dead for the last 6 years. Are you making this change just because it is needed to do the libjpeg-turbo fix or is this something you're actually trying to use? If the former, we should consider deindexing this thing rather than extensive patches. If the latter, do you have evidence of signs of life upstream?

Billy O'Neal (BillyONeal) · 2026-08-21T00:21:09Z

+    find_dependency(PkgConfig)
+    if(PkgConfig_FOUND)
+      pkg_check_modules(spng REQUIRED spng IMPORTED_TARGET)
+    endif()


Oh, I see, this is confusing because it's patches on patches. Kai Pastor (@dg0yt) I think your comment is resolved by 0002+0003 in this series.

Billy O'Neal (BillyONeal) · 2026-08-21T01:13:57Z

:sigh: The rabbit hole deepens. The vcpkg libspng port has confused pkgconfig bindings between static and dynamic. However, upstream is not consistent about it.

https://github.com/randy408/libspng/blob/adc94393dbeddf9e027d1b2dfff7c1bab975224e/CMakeLists.txt#L103-L107

installs libspng.pc and libspng_static.pc, but

https://github.com/randy408/libspng/blob/adc94393dbeddf9e027d1b2dfff7c1bab975224e/meson.build#L82-L87

installs spng.pc. This seems to be the one libjpeg-turbo is looking to be compatible with.

https://packages.debian.org/sid/amd64/libspng-dev/filelist Looks like Debian is using the meson build, given that they install /usr/lib/x86_64-linux-gnu/pkgconfig/spng.pc.

In vcpkg we want to make sure that CMake and pkg-config customers get an experience that works, including transitively. In reviewing microsoft/vcpkg#52891 we discovered that the transitive libjpeg-turbo -> libspng .pc link is broken. In trying to fix that I ran into a transitive problem here. https://github.com/randy408/libspng/blob/adc94393dbeddf9e027d1b2dfff7c1bab975224e/CMakeLists.txt#L103-L107 installs `libspng.pc` and `libspng_static.pc`, but https://github.com/randy408/libspng/blob/adc94393dbeddf9e027d1b2dfff7c1bab975224e/meson.build#L82-L87 installs `spng.pc`. This seems to be the one `libjpeg-turbo` is looking to be compatible with. https://packages.debian.org/sid/amd64/libspng-dev/filelist Looks like Debian is using the meson build, given that they install `/usr/lib/x86_64-linux-gnu/pkgconfig/spng.pc`. Also, meson detects whether the .pc should link with `libm` by probing for existence of the library: https://github.com/randy408/libspng/blob/adc94393dbeddf9e027d1b2dfff7c1bab975224e/meson.build#L42 while CMake just assumes "Windows gets no libm, everyone else does". This change changes everything to match meson. The problems discussed here and some of the suggested outcomes are from GPT 5.6 Sol.

Related: microsoft#52891 Related: randy408/libspng#286 This changes libspng to install pkg-config on all platforms matching that installed by Debian. Also fix the declared licenses to match the SPDX expression. Their README says: >## License > >Code is licensed under the BSD 2-clause "Simplified" License. > >The project contains optimizations and test images from libpng, these are licensed under the [PNG Reference Library License version 2](http://www.libpng.org/pub/png/src/libpng-LICENSE.txt). but they don't have a copy of the license. The content under that license is incorporated into the .c so we have to install the whole thing.

Billy O'Neal (BillyONeal) · 2026-08-21T02:21:19Z

I was going to throw up my hands and be like "well Windows pkgconfig is hopeless but at least we can make *nix work"; unfortunately that still runs into the problem that vcpkg's installed libspng.pc will not match up with what libjpeg-turbo wants. tartanpaint Unfortunately I think this means we need #53510 or something like it first, will keep you posted.

Billy O'Neal (BillyONeal) · 2026-08-21T02:23:50Z

(Alternately I suppose we could patch libjpeg-turbo to use the names vcpkg installs but given that we already have a submitted PR fixing libspng so that libjpeg-turbo does the right thing it's probably best to wait for that)

Thanks for your submission and sorry for the stream of consciousness :)

tartanpaint · 2026-08-21T07:02:45Z

(Alternately I suppose we could patch libjpeg-turbo to use the names vcpkg installs but given that we already have a submitted PR fixing libspng so that libjpeg-turbo does the right thing it's probably best to wait for that)

Thanks for your submission and sorry for the stream of consciousness :)

Billy O'Neal (@BillyONeal), thanks for taking a look at this - I hadn't realised what a can of worms I was opening when I started this....
The libfreenect2 changes simply came about due to me trying to resolve CI failures to get the PR mergable. I agree that the repo does appear dead with no commits for about 6 years and I do not use it myself. If a delist of the libfreenect2 library is desirable in this case I would not lament it.

I'm happy to clean this PR up once the libspng PR is merged and a decision is made on libfreenect2. I can produce a PR to delist libfreenect2 if that's helpful.

tartanpaint · 2026-08-21T07:05:06Z

Billy O'Neal (@BillyONeal) Kai Pastor (@dg0yt) - thanks for your continued assistance on this one.
Are you able to confirm that the libjpeg-turbo patches included from the libjpeg-turbo repo are acceptable, or are there additional upstream changes that we should look to have incorporated?
Thanks!

tartanpaint · 2026-08-21T08:18:54Z

(Alternately I suppose we could patch libjpeg-turbo to use the names vcpkg installs but given that we already have a submitted PR fixing libspng so that libjpeg-turbo does the right thing it's probably best to wait for that)
Thanks for your submission and sorry for the stream of consciousness :)

Billy O'Neal (Billy O'Neal (@BillyONeal)), thanks for taking a look at this - I hadn't realised what a can of worms I was opening when I started this.... The libfreenect2 changes simply came about due to me trying to resolve CI failures to get the PR mergable. I agree that the repo does appear dead with no commits for about 6 years and I do not use it myself. If a delist of the libfreenect2 library is desirable in this case I would not lament it.

I'm happy to clean this PR up once the libspng PR is merged and a decision is made on libfreenect2. I can produce a PR to delist libfreenect2 if that's helpful.

PR to deindex libfreenect2: #53516

Kai Pastor (dg0yt) · 2026-08-21T12:26:52Z

I don't have time for details before sunday.
Is pkgconfig for transitive spng really avoided now?
Is it still "patches on patches"?

tartanpaint · 2026-08-21T13:14:47Z

I don't have time for details before sunday. Is pkgconfig for transitive spng really avoided now? Is it still "patches on patches"?

Kai Pastor (@dg0yt) There is a pending PR that Billy O'Neal (@BillyONeal) prepared for the libspng issue: #53510

I think that the "patches on patches" referred to is the series of 3 commits that I generated patch files for from the upstream libjpeg-turbo repo. These are still in place. It was my intention that these will then be removed when the next version of libjpeg-turbo is added to vcpkg as that version will already contain these commits.

Billy O'Neal (BillyONeal) · 2026-08-22T06:16:43Z

I think that the "patches on patches" referred to is the series of 3 commits that I generated patch files for from the upstream libjpeg-turbo repo. These are still in place. It was my intention that these will then be removed when the next version of libjpeg-turbo is added to vcpkg as that version will already contain these commits.

Probably would be less confusing to prepare one patch and just comment that it is composed of the particular commits, e.g.

git apply A
git apply B
git apply C
git diff --cached --output out.diff

…peg-turbo-3.2.0-dependencies-patch

…as suggested

tartanpaint added 3 commits July 14, 2026 11:35

[libjpeg-turbo] Patch dependencies for 3.2.0

17ebbab

Fix manifest file formatting

41fb84e

Update version database

91a63a5

tartanpaint marked this pull request as draft July 14, 2026 21:56

tartanpaint added 3 commits July 15, 2026 10:17

Updated libjpeg-turbo patch with Pkg-Config fixes

5f44fec

Fix libjpeg-turbo license in manifest

9be746e

Update version database

b666138

Marian Klymov (Nekto89) mentioned this pull request Jul 17, 2026

libjpeg-turbo: publish version 3.2.0 conan-io/conan-center-index#30568

Merged

4 tasks

tartanpaint added 15 commits July 17, 2026 17:56

Update with dependency patches from libjpeg-turbo project

1d4b86e

Update version database

816a4bf

Merge branch 'microsoft:master' into libjpeg-turbo-3.2.0-dependencies…

f7ef5cf

…-patch

Patch libfreenect2 FindTurboJPEG.cmake to try to fix CI build

9dd768c

Expect failures for openslide for x64-windows-static and x64-windows-…

be1bb27

…static-md since MSVC is not supported

Bump port version for libfreenect2

808b8b5

Update version database

12b63c7

Fix format issue

bb02239

Fix libfreenect2 build with patch from OpenKinect/libfreenect2#1209

87954ac

Update version database

50c6f20

Merge branch 'microsoft:master' into libjpeg-turbo-3.2.0-dependencies…

32ddf85

…-patch

Attempt to fix finding libjpeg-turbo and dependencies for libfreenect2

57b099a

Update version database

af1e9e9

Update libfreenect2 to support finding static libjpeg-turbo libs

4d62c34

Update version database

8714cb6

Kai Pastor (dg0yt) reviewed Aug 6, 2026

View reviewed changes

tartanpaint added 5 commits August 8, 2026 18:24

Merge branch 'microsoft:master' into libjpeg-turbo-3.2.0-dependencies…

9ac1bd8

…-patch

Fix libfreenect2 cross compile resource generation with patch from Co…

924e41f

…nan conan-io/conan-center-index#7628

Update version database

b8ebb3b

Remove expected failure for libfreenect2:arm64-windows as this now pa…

c396cd1

…sses

Update libfreenect2 find_libjpegturbo.patch as per review

622c0b8

tartanpaint added 7 commits August 19, 2026 08:25

Provide comments referencing specific libjpeg-turbo commits used for …

fdfabe3

…patches

Update version database

63ac7fd

Attempt to fix libfreenect2 finding libjpeg-turbo files

46229a2

Update version database

a3fde3e

Merge branch 'microsoft:master' into libjpeg-turbo-3.2.0-dependencies…

3df5533

…-patch

Try to simplify libfreenect2 FindTurboJPEG patch

863daa7

Update version database

adefe48

tartanpaint marked this pull request as ready for review August 20, 2026 06:49

Billy O'Neal (BillyONeal) reviewed Aug 21, 2026

View reviewed changes

Billy O'Neal (BillyONeal) mentioned this pull request Aug 21, 2026

Change CMake generated pkgconfig to match meson. randy408/libspng#286

Open

Billy O'Neal (BillyONeal) mentioned this pull request Aug 21, 2026

[libspng] Install pkg-config on Windows #53510

Open

Billy O'Neal (BillyONeal) added the depends:different-pr This PR or Issue depends on a PR which has been filed label Aug 21, 2026

tartanpaint mentioned this pull request Aug 21, 2026

[libfreenect2] Deindex #53516

Merged

tartanpaint added 6 commits August 22, 2026 10:31

Merge branch 'master' of https://github.com/microsoft/vcpkg into libj…

5daa276

…peg-turbo-3.2.0-dependencies-patch

Consolidate upstream libjpeg-turbo commits in to a single patch file …

268667a

…as suggested

Update version database

b275109

Fix libjpeg-turbo port line endings

9944b28

Update version database

12c6dea

Update version database

8516d07

		-CMAKE_MINIMUM_REQUIRED(VERSION 2.8.12.1)
		+CMAKE_MINIMUM_REQUIRED(VERSION 3.5)

	+ find_package(libjpeg-turbo CONFIG)
	+ find_package(TurboJPEG NAMES libjpeg-turbo)

Uh oh!

Conversation

tartanpaint commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Billy O'Neal (BillyONeal) commented Jul 14, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Billy O'Neal (BillyONeal) left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Billy O'Neal (BillyONeal) commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Billy O'Neal (BillyONeal) commented Aug 21, 2026

Uh oh!

Billy O'Neal (BillyONeal) commented Aug 21, 2026

Uh oh!

tartanpaint commented Aug 21, 2026

Uh oh!

tartanpaint commented Aug 21, 2026

Uh oh!

tartanpaint commented Aug 21, 2026

Uh oh!

Kai Pastor (dg0yt) commented Aug 21, 2026

Uh oh!

tartanpaint commented Aug 21, 2026

Uh oh!

Billy O'Neal (BillyONeal) commented Aug 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tartanpaint commented Jul 14, 2026 •

edited

Loading

Billy O'Neal (BillyONeal) commented Aug 21, 2026 •

edited

Loading

Billy O'Neal (BillyONeal) commented Aug 22, 2026 •

edited

Loading