Skip to content

[mongo-c-driver, poco] Remove unofficial-utf8proc use - #52645

Merged
Billy O'Neal (BillyONeal) merged 9 commits into
microsoft:masterfrom
moyer-avs:remove-unofficial-utf8proc
Aug 21, 2026
Merged

[mongo-c-driver, poco] Remove unofficial-utf8proc use#52645
Billy O'Neal (BillyONeal) merged 9 commits into
microsoft:masterfrom
moyer-avs:remove-unofficial-utf8proc

Conversation

@moyer-avs

@moyer-avs Alexandre Moyer (moyer-avs) commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hello,

Following #47400, find_package(unofficial-utf8proc) is now deprecated, causing warnings when building poco, mongo-c-driver and any project depending on them.

This PR fixes it, it migrates both ports from the deprecated unofficial-utf8proc to the canonical config now provided by utf8proc port (find_package(utf8proc CONFIG REQUIRED) / utf8proc::utf8proc).

Tested on Windows 11 with MSVC v143 (x64-windows).

  • Changes comply with the maintainer guide.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

@moyer-avs

Alexandre Moyer (moyer-avs) commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="AVSimulation"

@moyer-avs
Alexandre Moyer (moyer-avs) marked this pull request as ready for review August 18, 2026 14:52
Copilot AI added 3 commits August 18, 2026 17:09
[mongo-c-driver,poco] Fix exported usage and dependencies
e370a39 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
[poco] Let find_dependency propagate requiredness
b6bec8b 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
[mongo-c-driver,poco] Preserve contributor versions
a4d6278 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@BillyONeal Billy O'Neal (BillyONeal) changed the title Remove unofficial-utf8proc use [mongo-c-driver, poco] Remove unofficial-utf8proc use Aug 19, 2026
[poco] Preserve upstream PCRE2 comment
f18faa9 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
BillyONeal
Billy O'Neal (BillyONeal) requested changes Aug 19, 2026
View reviewed changes

@BillyONeal Billy O'Neal (BillyONeal) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our review bits https://github.com/microsoft/vcpkg/blob/master/.github/skills/shared/review-vcpkg-pr-guide.md plus GPT 5.6 Sol plus your PR generated a bunch of comments for other problems we might want to fix while we are here. Would you consider moyer-avs#1 ?

It's entirely reasonable if you don't want to go there, if so just let me know and I'll make those fixes as a separate change.

The main thing from there that I think we should fix either way is the declared license content for poco.

@BillyONeal

Billy O'Neal (BillyONeal) commented Aug 19, 2026

Copy link
Copy Markdown
Member

Oh, and thanks for the fix!

@BillyONeal

Billy O'Neal (BillyONeal) commented Aug 19, 2026

Copy link
Copy Markdown
Member

Since you 👍 'd my comment above I'm interpreting that as "comment has been read"; please consider moyer-avs#1 and either merge it or explain that you don't want to do that and mark "Ready for review"

@BillyONeal
Billy O'Neal (BillyONeal) marked this pull request as draft August 19, 2026 17:31
@moyer-avs

Alexandre Moyer (moyer-avs) commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

I will probably merge, just need to read it.
Something came up today,will do tomorrow.

@moyer-avs
Merge pull request #1 from BillyONeal/pr-52645-mongo-c-driver-poco
5b130d4 
[mongo-c-driver, poco] utf8proc nitpicks
@moyer-avs

Alexandre Moyer (moyer-avs) commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Hello,
Merge is done.
I left 2 questions in a comment on moyer-avs#1 though.
If you have a minute to answer it for my personal knowledge, thank you in advance.

@moyer-avs
Alexandre Moyer (moyer-avs) marked this pull request as ready for review August 20, 2026 23:47
BillyONeal
Billy O'Neal (BillyONeal) previously approved these changes Aug 20, 2026
View reviewed changes

@BillyONeal Billy O'Neal (BillyONeal) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I also replied over there.

@BillyONeal
Billy O'Neal (BillyONeal) enabled auto-merge (squash) August 20, 2026 23:53
auto-merge was automatically disabled August 21, 2026 00:16

Head branch was pushed to by a user without write access

@BillyONeal

Billy O'Neal (BillyONeal) commented Aug 21, 2026

Copy link
Copy Markdown
Member

Sorry I missed that 😅

@BillyONeal
Billy O'Neal (BillyONeal) enabled auto-merge (squash) August 21, 2026 02:30
@BillyONeal
Billy O'Neal (BillyONeal) merged commit 7f3781e into microsoft:master Aug 21, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal Billy O'Neal (BillyONeal) BillyONeal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@moyer-avs @BillyONeal