Repository navigation
tailor: log swallowed cleanup and cache errors - #872
Open
Paco Huelsz (frhuelsz) wants to merge 1 commit into
Open
Paco Huelsz (frhuelsz) wants to merge 1 commit into
Paco Huelsz (frhuelsz) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes add diagnostics without altering cleanup, fallback, or error-propagation behavior, and no blocking issues were identified.
No open issues 🎉
What changed in this PR
Adds warnings for previously ignored cleanup and cache errors in Tailor while preserving best-effort behavior and existing error propagation.
Changes:
- Logs failures when scanning or removing staging directories and cleaning up working copies.
- Reports incomplete tools-directory cache removal and base-hash cache setup failures.
- Warns when invalid signing configuration may leave CA certificates behind during cleanup.
| File | Description |
|---|---|
tools/tailor/crates/tailor/src/run.rs |
Adds warnings for conversion cleanup, cache setup, and signing resolution during clean. |
tools/tailor/crates/tailor-exec/src/output_artifacts.rs |
Logs directory scan and entry-read errors during stale staging discovery. |
tools/tailor/crates/tailor-exec/src/executor.rs |
Centralizes working-copy cleanup warnings and reports incomplete cache removal failures. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warn when best-effort cleanup or cache setup fails instead of silently discarding the error. Covers stale staging scans, working-copy and conversion cleanup, partial tools-dir cache removal, invalid signing during clean, and base-hash cache setup. Existing failure/cleanup behavior is unchanged.
Validated with
cd tools/tailor && just check.