Repository navigation
fix: update rustls to 0.23.46 to resolve new RUSTSEC advisories - #855
Merged
Merged
Conversation
RUSTSEC-2026-0347/0348/0349 were published against rustls 0.23.45 (the version #847 bumped to for RUSTSEC-2026-0285), making it vulnerable again: an ECH-rejection plaintext leak, an unbounded brotli decompression allocation, and a PQ key-exchange downgrade. All are fixed in rustls 0.23.46. Updates both the root Cargo.lock (ACL agent kube client path) and tools/tailor/Cargo.lock (oci-client/reqwest path, the lockfile cargo-deny CI actually checks). Regenerates NOTICE for the root workspace. No source or manifest changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped dependency updates are consistent, reported validation supports them, and no blocking issues remain.
0 open findings
What changed in this PR
Updates rustls to 0.23.46 in both workspaces to address three security advisories and unblock Tailor dependency checks.
Changes:
- Updates rustls versions and checksums in both lockfiles.
- Refreshes the root dependency notice; no source or manifest changes.
| File | Description |
|---|---|
| tools/tailor/Cargo.lock | Updates Tailor’s rustls dependency. |
| NOTICE | Records the updated rustls version. |
| Cargo.lock | Updates the root workspace’s rustls dependency. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
fintelia
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update rustls from 0.23.45 to 0.23.46 in both the root
Cargo.lockandtools/tailor/Cargo.lock. RegenerateNOTICEfor the root workspace. No source or manifest changes.Rationale
#847 bumped rustls to 0.23.45 to fix RUSTSEC-2026-0285. Since then, three new advisories were published against 0.23.45 itself:
All three are fixed in rustls >=0.23.46. This is currently failing
cargo-denyonmainand blocking PR #842 (tools/tailorresolves rustls 0.23.45 viaoci-client->reqwest/hyper-rustls/tokio-rustls).Validation
cargo update -p rustls(root workspace)cargo update -p rustls(tools/tailor workspace)cargo deny checkintools/tailoradvisories ok, bans ok, licenses ok, sources ok- this is the lockfile thecargo-denyCI job actually checks.cargo deny checkat repo rootcargo-denyis not wired into CI (onlytools/tailoris, via.github/workflows/tailor.yml), and the remaining failures (bannedring, several unmaintained-crate warnings, h2/quick-xml advisories) predate this change.cargo check --locked --workspaceintools/tailorcargo check --locked -p trident -p trident-acl-agent --features dangerous-options,grpc-previewcargo test --locked -p trident-acl-agent --libmake update-noticeNOTICE; only the rustls version entry changed.git diff --check