Skip to content

Remove testing environment references from socket mode sample - #669

Merged
teddy arida-moody (teddyam) merged 5 commits into
mainfrom
teddyam-socket-mode-release-cleanup
Nov 5, 2026
Merged

teddy arida-moody (teddyam) merged 5 commits into
mainfrom
teddyam-socket-mode-release-cleanup

Conversation

@teddyam

Copy link
Copy Markdown
Contributor

Prepare Socket Mode for general availability by removing testing-ring configuration and guidance from the sample.

  • Use App(socket_mode=True) so the sample connects to the existing production default instead of Canary.
  • Remove Canary/Pilot1 endpoint guidance, the production-503 claim, and the custom-ring recommendation from the README.
  • Replace real Canary hostnames in adapter tests with https://botapi.example, preserving endpoint-override coverage.

The public negotiate_base_url option, preview warnings, and development-only/Marketplace guidance remain unchanged.

Validation: 47 adapter tests pass; Ruff formatting, lint, and Pyright pass. The echo sample starts and exposes its messaging endpoint. Live Socket Mode connectivity was not exercised.

Use the production socket mode defaults, remove testing-ring guidance, and use a placeholder hostname in adapter tests.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI max review requested due to automatic review settings November 4, 2026 21:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

An unresolved README nit leaves the geos override unclear because the example omits SocketModeOptions, even though geos is not an App keyword.

1 open issue
What changed in this PR

Aligns the Teams SDK’s Socket Mode sample with the existing production default while preserving the public configuration API, preview warnings, and development-only restrictions.

Changes:

  • Simplifies the sample to use App(socket_mode=True).
  • Removes testing-ring guidance and the production-503 claim from the README.
  • Replaces Canary URLs in tests with a neutral example URL, preserving endpoint-override coverage.
File Description
packages/​apps/​tests/​test_socket_mode_adapter.py Uses https://botapi.example in endpoint-override tests.
examples/​socket/​src/​main.py Removes the Canary override and unused options import.
examples/​socket/​README.md Removes testing-ring recommendations and obsolete production limitations.

Review effort: Max

Comment thread examples/socket/README.md Resolved
Comment thread examples/socket/README.md Resolved
Document geo and endpoint overrides in API docstrings, recommend Socket Mode for new bots, and remove override guidance from the sample README.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI max review requested due to automatic review settings November 5, 2026 01:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new-bot recommendation can be mistaken for production guidance because it lacks an explicit development-only qualifier in the adapter and matching docstrings.

1 open issue
1 resolved since last review

Review effort: Max

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI max review requested due to automatic review settings November 5, 2026 17:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The socket example README omits Socket Mode’s new-bot prerequisite, so users following it with an existing bot may fail to connect.

1 open issue
1 resolved since last review

Review effort: Max

Comment thread examples/socket/README.md Resolved
Updated README to clarify Socket Mode features and usage.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI max review requested due to automatic review settings November 5, 2026 18:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Socket Mode documentation leaves “new bots” undefined, so readers cannot tell whether their existing bot is eligible to use the sample.

1 open issue
1 resolved since last review

Review effort: Max

Comment thread examples/socket/README.md Resolved
Copilot AI max review requested due to automatic review settings November 5, 2026 18:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The README edit removes the only guidance for overriding default geographies alongside the intended custom-ring cleanup, leaving an outstanding documentation nit.

1 open issue

Review effort: Max

@teddyam
teddy arida-moody (teddyam) merged commit bf9f75d into main Nov 5, 2026
9 checks passed
@teddyam
teddy arida-moody (teddyam) deleted the teddyam-socket-mode-release-cleanup branch November 5, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants