Repository navigation
Remove testing environment references from socket mode sample - #669
Merged
teddy arida-moody (teddyam) merged 5 commits intoNov 5, 2026
Merged
Conversation
Use the production socket mode defaults, remove testing-ring guidance, and use a placeholder hostname in adapter tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
An unresolved README nit leaves the geos override unclear because the example omits SocketModeOptions, even though geos is not an App keyword.
1 open issue
What changed in this PR
Aligns the Teams SDK’s Socket Mode sample with the existing production default while preserving the public configuration API, preview warnings, and development-only restrictions.
Changes:
- Simplifies the sample to use
App(socket_mode=True). - Removes testing-ring guidance and the production-503 claim from the README.
- Replaces Canary URLs in tests with a neutral example URL, preserving endpoint-override coverage.
| File | Description |
|---|---|
packages/apps/tests/test_socket_mode_adapter.py |
Uses https://botapi.example in endpoint-override tests. |
examples/socket/src/main.py |
Removes the Canary override and unused options import. |
examples/socket/README.md |
Removes testing-ring recommendations and obsolete production limitations. |
Review effort: Max
Document geo and endpoint overrides in API docstrings, recommend Socket Mode for new bots, and remove override guidance from the sample README. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Updated README to clarify Socket Mode features and usage. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Lily Du (lilyydu)
approved these changes
Nov 5, 2026
Lily Du (lilyydu)
approved these changes
Nov 5, 2026
teddy arida-moody (teddyam)
deleted the
teddyam-socket-mode-release-cleanup
branch
November 5, 2026 18:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Prepare Socket Mode for general availability by removing testing-ring configuration and guidance from the sample.
App(socket_mode=True)so the sample connects to the existing production default instead of Canary.https://botapi.example, preserving endpoint-override coverage.The public
negotiate_base_urloption, preview warnings, and development-only/Marketplace guidance remain unchanged.Validation: 47 adapter tests pass; Ruff formatting, lint, and Pyright pass. The echo sample starts and exposes its messaging endpoint. Live Socket Mode connectivity was not exercised.