Repository navigation
Remove Socket Mode URL diagnostic and reject case-variant geos - #730
Merged
teddy arida-moody (teddyam) merged 1 commit intoNov 10, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are blocking approval.
No open issues 🎉
What changed in this PR
This PR narrows Socket Mode’s experimental diagnostic API and prevents case-variant geo names from creating separate connections to the same hostname.
Changes:
- Remove
NegotiateUrlfrom the public observer and internal transport, along with related documentation and assertions. - Reject duplicate geos using ordinal, case-insensitive comparison while preserving individual uppercase geo names.
- Update regression coverage and document the geo uniqueness requirement.
| File | Description |
|---|---|
test/Microsoft.Teams.Apps.UnitTests/SocketMode/SocketModeTransportTests.cs |
Tests mixed-case duplicate rejection and single uppercase geo support. |
test/Microsoft.Teams.Apps.UnitTests/SocketMode/SocketModeObserverTests.cs |
Removes the obsolete URL diagnostic assertion. |
test/Microsoft.Teams.Apps.UnitTests/SocketMode/SocketModeHostingTests.cs |
Removes the obsolete URL assertion from hosting coverage. |
src/Microsoft.Teams.Apps/SocketMode/SocketModeTransport.cs |
Enforces case-insensitive uniqueness and removes the internal URL getter. |
src/Microsoft.Teams.Apps/SocketMode/SocketModeOptions.cs |
Documents non-empty, case-insensitively unique geo entries. |
src/Microsoft.Teams.Apps/SocketMode/SocketModeObserver.cs |
Removes the public NegotiateUrl property. |
src/Microsoft.Teams.Apps/README.md |
Updates the list of available diagnostics. |
Review effort: Balanced
Lily Du (lilyydu)
approved these changes
Nov 10, 2026
teddy arida-moody (teddyam)
deleted the
teddyam-socket-mode-url-exposure
branch
November 10, 2026 02:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Socket Mode should not expose its temporary negotiation endpoint through a public diagnostic API. Geo names that differ only by case also resolve to the same hostname and must not create independently supervised connections to that host.
Changes
SocketModeObserver.NegotiateUrland its unused internal getter, along with related documentation and assertions. Connection behavior and startup URL logging are unchanged. External callers using this experimental property must remove that usage.["amer", "AMER"]into rejection coverage and retain a successful single-geo"AMER"case. Document the uniqueness requirement.Validation