Fix Socket Mode connect URL geo routing by teddyam · Pull Request #729 · microsoft/teams.net

teddy arida-moody (teddyam) · 2026-11-09T19:37:13Z

Summary

Route Socket Mode connect/negotiate requests through {geo}.botapi.skype.com instead of botapi.skype.com/{geo}, matching fix: update connect URL to target correct geo teams.py#676.
Remove the configurable endpoint override (SocketModeOptions.NegotiateBaseUrl); only Geos remains configurable.
An empty geo list (Geos = []) uses the defaults: amer, emea, and apac. An empty geo string (Geos = [""], or an empty string within a non-empty list) is rejected; it no longer bypasses geo-specific routing.
Log each resolved connect/negotiate URL at Information during startup so it appears with the sample's default logging configuration.
Update routing coverage and documentation. Authentication scopes, returned SignalR URLs, and other API calls remain unchanged.

Public API change

Removing SocketModeOptions.NegotiateBaseUrl is a source-breaking change for callers that set the endpoint override. Remove that assignment and use Geos to select the connections instead; custom endpoint overrides are no longer supported.
Callers using an empty string to connect without a geo must select a geo instead, or use an empty list to connect to all three defaults. An empty list and an empty string have different behavior: [] uses defaults; [""] is rejected.

Validation

Socket Mode tests passed on .NET 8 and .NET 10: 224 tests per framework.
User verified the production geo routing locally with the SocketModeBot sample.

Use geo subdomains for production connect requests while preserving custom endpoint routing and authentication scopes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Include the geo and SignalR endpoint on each connection attempt, omitting URL credentials, query strings, and fragments. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Show per-geo connection URLs with the existing logging configuration. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Use geo subdomains for custom connect hosts, preserving base paths, ports, and queries. Log resolved negotiate URLs at Debug during startup instead of logging returned SignalR endpoints at Information. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Drop the leftover callback test from the earlier SignalR logging approach and consolidate overlapping custom-host and empty-geo cases. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Log negotiated SignalR endpoints at Information alongside transport lifecycle logs. Preserve Python-aligned connect routing and Debug diagnostics, and omit sensitive URL components from the new log. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Keep connection and geo-routing coverage without asserting diagnostic output or adding logging-only fixtures. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Remove returned SignalR endpoint logging and its callback plumbing. Keep Python-aligned negotiate URL diagnostics visible with the sample defaults and remove the returned-endpoint README notes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

azure-pipelines · 2026-11-09T19:37:24Z

Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run.

Copilot

🟡 Changes recommended

URL construction mishandles empty-geo URLs containing queries or fragments and prefixes loopback hosts with a geo, causing negotiation to target the wrong path or fail before sending a request.

2 open issues

What changed in this PR

This PR updates Socket Mode connect routing to use geo subdomains, aligning the .NET transport with the intended production endpoints.

Changes:

Replace geo path segments with subdomains for production and custom hosts.
Log resolved connect URLs at Information level during startup.
Update routing tests and documentation, and exercise a query-bearing SignalR URL.

File	Description
test/Microsoft.Teams.Apps.UnitTests/SocketMode/SocketModeTransportTests.cs	Update routing expectations and add custom-host cases.
test/Microsoft.Teams.Apps.UnitTests/SocketMode/SocketModeObserverTests.cs	Expect geo-subdomain diagnostic URLs.
test/Microsoft.Teams.Apps.UnitTests/SocketMode/SocketModeHostingTests.cs	Update the hosted transport URL expectation.
test/Microsoft.Teams.Apps.UnitTests/SocketMode/SocketModeEndToEndTests.cs	Update endpoint assertions and fake geo extraction.
test/Microsoft.Teams.Apps.UnitTests/SocketMode/SignalRSocketConnectionTests.cs	Include a query parameter in the SignalR URL fixture.
src/Microsoft.Teams.Apps/SocketMode/SocketModeTransport.cs	Build geo-subdomain URLs and log them during startup.
src/Microsoft.Teams.Apps/SocketMode/SocketModeProtocol.cs	Clarify the negotiate-path comment.
src/Microsoft.Teams.Apps/SocketMode/SocketModeOptions.cs	Document subdomain routing and empty-geo behavior.
src/Microsoft.Teams.Apps/README.md	Describe production routing, custom hosts, and URL logging.
samples/SocketModeBot/README.md	Show the production geo-specific connect endpoints.

_{Review effort: Balanced}

Do not imply support for geo-prefixed HTTP localhost endpoints that the real negotiator rejects. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Use UriBuilder for every geo, keeping only the host prefix conditional. Preserve query parameters and discard fragments when appending the connect path; cover empty geos with exact URL regression cases. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

🔵 Needs a closer look

The empty-geo branch appends the connect endpoint to the full base URL rather than its path, causing URLs with queries or fragments to send negotiation requests to the wrong endpoint.

No open issues 🎉

2 resolved since last review

_{Review effort: Balanced}

Copilot

🟢 Approval recommended

No active review issues remain for the Socket Mode geo-subdomain routing update.

No open issues 🎉

_{Review effort: Balanced}

Arup Roy (aroy-ms)

approving with 1 suggestion

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

🟢 Approval recommended

No active review issues block the Socket Mode geo-subdomain routing change.

No open issues 🎉

_{Review effort: Balanced}

Use smbatrafficmanager.net for Socket Mode connect requests, remove configurable negotiate base URLs, and require at least one geo. Preserve unrelated authentication scopes and CompatBot URLs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

🟡 Changes recommended

Insufficient geo validation can send Bot Framework bearer tokens to an attacker-controlled host, and the service domain differs from the documented endpoint.

2 open issues

Validate geo values as single DNS labels · New
Use the intended botapi.skype.com endpoint · New

_{Review effort: Balanced}

Restore geo-prefixed botapi.skype.com endpoints, default empty geo lists, and check exact empty strings and case-sensitive duplicates. Escape geo URL components, simplify tests, and remove unnecessary endpoint documentation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

🟡 Changes recommended

The PR description needs updating because it promises endpoint overrides and empty geo string support, while the revision removes NegotiateBaseUrl and rejects empty geo strings.

1 open issue

PR description misstates endpoint override and empty-geo behavior · New

2 resolved since last review

_{Review effort: Balanced}

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

🟢 Approval recommended

The review identifies no active issues with the geo-specific Socket Mode routing and configuration changes.

No open issues 🎉

1 resolved since last review

PR description misstates endpoint override and empty-geo behavior

_{Review effort: Balanced}

Arup Roy (aroy-ms)

approving latest iteration

Teddy Arida-Moody and others added 8 commits November 9, 2026 10:26

Fix Socket Mode connect geo routing

c5ad448

Use geo subdomains for production connect requests while preserving custom endpoint routing and authentication scopes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Log negotiated SignalR endpoints per geo at debug level

22af428

Include the geo and SignalR endpoint on each connection attempt, omitting URL credentials, query strings, and fragments. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Log SignalR endpoints at Information level

cef68aa

Show per-geo connection URLs with the existing logging configuration. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Remove redundant Socket Mode regression tests

fd849d5

Drop the leftover callback test from the earlier SignalR logging approach and consolidate overlapping custom-host and empty-geo cases. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Remove URL logging-specific test additions

d4863a5

Keep connection and geo-routing coverage without asserting diagnostic output or adding logging-only fixtures. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI balanced review requested due to automatic review settings November 9, 2026 19:37

Copilot started reviewing on behalf of teddy arida-moody (teddyam) November 9, 2026 19:37

View session

Copilot AI reviewed Nov 9, 2026

View reviewed changes

Comment thread src/Microsoft.Teams.Apps/SocketMode/SocketModeTransport.cs Resolved

Comment thread src/Microsoft.Teams.Apps/SocketMode/SocketModeTransport.cs Resolved

Remove misleading localhost geo routing test case

40016d6

Do not imply support for geo-prefixed HTTP localhost endpoints that the real negotiator rejects. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI balanced review requested due to automatic review settings November 9, 2026 19:48

Copilot started reviewing on behalf of teddy arida-moody (teddyam) November 9, 2026 19:49

View session

Copilot AI reviewed Nov 9, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings November 9, 2026 19:51

Copilot started reviewing on behalf of teddy arida-moody (teddyam) November 9, 2026 19:51

View session

Copilot AI reviewed Nov 9, 2026

View reviewed changes

Arup Roy (aroy-ms) reviewed Nov 9, 2026

View reviewed changes

Comment thread src/Microsoft.Teams.Apps/SocketMode/SocketModeTransport.cs Resolved

Arup Roy (aroy-ms) reviewed Nov 9, 2026

View reviewed changes

Comment thread test/Microsoft.Teams.Apps.UnitTests/SocketMode/SocketModeEndToEndTests.cs Resolved

Arup Roy (aroy-ms) approved these changes Nov 9, 2026

View reviewed changes

Arup Roy (aroy-ms) requested a review from Andrei Todorov (andreitodorov) November 9, 2026 20:21

Andrei Todorov (andreitodorov) reviewed Nov 9, 2026

View reviewed changes

Comment thread src/Microsoft.Teams.Apps/SocketMode/SocketModeTransport.cs Resolved

Andrei Todorov (andreitodorov) approved these changes Nov 9, 2026

View reviewed changes

Use null-safe geo length check in connection logging

56b73fb

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI balanced review requested due to automatic review settings November 9, 2026 20:46

Copilot started reviewing on behalf of teddy arida-moody (teddyam) November 9, 2026 20:47

View session

Copilot AI reviewed Nov 9, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings November 9, 2026 22:20

Copilot started reviewing on behalf of teddy arida-moody (teddyam) November 9, 2026 22:20

View session

Copilot AI reviewed Nov 9, 2026

Correct Socket Mode host to smba.trafficmanager.net

b275849

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI balanced review requested due to automatic review settings November 9, 2026 22:23

Copilot started reviewing on behalf of teddy arida-moody (teddyam) November 9, 2026 22:24

View session

Copilot AI reviewed Nov 9, 2026

View reviewed changes

Comment thread src/Microsoft.Teams.Apps/SocketMode/SocketModeTransport.cs Resolved

Comment thread src/Microsoft.Teams.Apps/SocketMode/SocketModeProtocol.cs Resolved

Copilot AI balanced review requested due to automatic review settings November 9, 2026 23:39

Copilot started reviewing on behalf of teddy arida-moody (teddyam) November 9, 2026 23:40

View session

Copilot AI reviewed Nov 9, 2026

View reviewed changes

Comment thread src/Microsoft.Teams.Apps/SocketMode/SocketModeOptions.cs Resolved

Lily Du (lilyydu) approved these changes Nov 9, 2026

View reviewed changes

Document SDK-managed Socket Mode negotiation URLs

868d6dc

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI balanced review requested due to automatic review settings November 10, 2026 00:03

Copilot started reviewing on behalf of teddy arida-moody (teddyam) November 10, 2026 00:03

View session

Copilot AI reviewed Nov 10, 2026

View reviewed changes

Arup Roy (aroy-ms) approved these changes Nov 10, 2026

View reviewed changes

teddy arida-moody (teddyam) added this pull request to the merge queue Nov 10, 2026

Merged via the queue into main with commit 9af1000 Nov 10, 2026
7 checks passed

teddy arida-moody (teddyam) deleted the teddyam-fix-connect-geo-url branch November 10, 2026 00:10

teddy arida-moody (teddyam) mentioned this pull request Nov 10, 2026

Release 2.2.1: cherry-pick Socket Mode routing fixes #731

Merged

Conversation

teddy arida-moody (teddyam) commented Nov 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Public API change

Validation

Uh oh!

azure-pipelines Bot commented Nov 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Uh oh!

Uh oh!

Arup Roy (aroy-ms) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Arup Roy (aroy-ms) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

teddy arida-moody (teddyam) commented Nov 9, 2026 •

edited

Loading