Unify PySCF and GPU4PySCF nuclear-gradient computation - #131
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Unifies CPU and GPU nuclear-gradient calculations through shared PyTorch utilities and updates Pixi tooling.
Changes:
- Adds shared feature differentiation, grid slicing, and AO/XC contraction helpers.
- Refactors PySCF and GPU4PySCF gradient adapters to use shared logic.
- Adds focused tests and upgrades Pixi to 0.78.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
skala/src/skala/pyscf/gradient_core.py |
Adds shared gradient operations. |
skala/src/skala/pyscf/gradients.py |
Adopts shared CPU gradient logic. |
skala/src/skala/gpu4pyscf/gradients.py |
Adopts shared GPU gradient logic. |
skala/tests/test_gradient_core.py |
Tests shared gradient operations. |
pixi.toml |
Requires Pixi 0.78. |
pixi.lock |
Refreshes platform identifiers. |
.github/workflows/skala-test.yml |
Updates Pixi in runtime CI. |
.github/workflows/pypi.yml |
Updates Pixi in release CI. |
.github/workflows/model-test.yml |
Updates Pixi in model tests. |
.github/workflows/model-examples.yml |
Updates Pixi in model examples. |
.github/workflows/model-benchmark.yml |
Updates Pixi in benchmarks. |
.github/workflows/lint.yml |
Updates Pixi in lint CI. |
.github/workflows/gauxc-test.yml |
Updates Pixi in GauXC tests. |
.github/workflows/examples.yml |
Updates Pixi in example CI. |
.github/workflows/docs.yml |
Updates Pixi in documentation CI. |
.github/workflows/benchmark-test.yml |
Updates Pixi in benchmark tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Jens (JensWehner)
requested review from
Sebastian Ehlert (awvwgk) and
Jan Hermann (jhrmnn)
September 2, 2026 08:40
Thijs Vogels (tvogels)
previously approved these changes
Sep 3, 2026
Jan Hermann (jhrmnn)
previously approved these changes
Sep 3, 2026
Co-authored-by: Thijs Vogels <840825+tvogels@users.noreply.github.com>
Jens (JensWehner)
dismissed stale reviews from Jan Hermann (jhrmnn) and Thijs Vogels (tvogels)
via
September 3, 2026 13:02
96004c9
Thijs Vogels (tvogels)
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.