Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
766234a
implement screening
JensWehner Jul 31, 2026
658c264
add docstrings
JensWehner Jul 31, 2026
eaf5d1c
add failing test for consistency
JensWehner Jul 31, 2026
a4dad08
add docstring and use dense eval
JensWehner Jul 31, 2026
3fe4371
work on shell screening
JensWehner Aug 3, 2026
abee701
add nuclear gradient test
JensWehner Aug 3, 2026
9428b67
add memory benchmark
JensWehner Aug 3, 2026
8ad6f33
remove chunked case
JensWehner Aug 4, 2026
0343e37
Apply suggestions from code review
JensWehner Aug 4, 2026
9885e84
refactor tests
JensWehner Aug 4, 2026
a02c507
fix consistent screened response memory policy
JensWehner Aug 5, 2026
0fc36be
refactor remove unsupported kinetic tensor features
JensWehner Aug 5, 2026
a425a10
refactor extract chunk evaluation helpers
JensWehner Aug 5, 2026
a6676cf
refactor centralize feature evaluation policy
JensWehner Aug 5, 2026
5783c7a
refactor isolate feature mathematics
JensWehner Aug 5, 2026
d299389
refactor isolate ao autograd evaluation
JensWehner Aug 5, 2026
683e350
refactor isolate screened feature evaluation
JensWehner Aug 5, 2026
92ef053
refactor make screened grid cache explicit
JensWehner Aug 5, 2026
60385d5
refactor separate xc integration from pyscf adapter
JensWehner Aug 5, 2026
1307736
make functions private
JensWehner Aug 5, 2026
428c393
Potential fix for pull request finding
JensWehner Aug 6, 2026
5c0d8db
fix screening in the cpu case
JensWehner Aug 6, 2026
eec82b4
use pca grid decomposition
JensWehner Aug 7, 2026
cda8010
use enum and rework switch size patching
JensWehner Aug 7, 2026
55fe903
fix enum properly
JensWehner Aug 7, 2026
f5fa1f2
make tests nicer
JensWehner Aug 7, 2026
28cf7ef
make tests nicer
JensWehner Aug 7, 2026
8a3b114
fix doc tests
JensWehner Aug 7, 2026
740085d
clean notebooks
JensWehner Aug 7, 2026
c0a4a9d
commit notebooks for analysis
JensWehner Aug 7, 2026
5114d3b
improve model chunking
JensWehner Aug 8, 2026
26fa246
use analytic vjp for backpropagation of ml model outputs to density m…
JensWehner Aug 8, 2026
af88a1c
small optimisation
JensWehner Aug 8, 2026
59b020b
use newer pyscf version in test
JensWehner Aug 10, 2026
01a42db
pin versions
JensWehner Aug 10, 2026
130bced
raise error bound
JensWehner Aug 10, 2026
0308eb8
Make linear model simpler and add test
JensWehner Aug 10, 2026
c56a14a
require special skala grids
JensWehner Aug 10, 2026
eddd046
add pyscf 2.9 fixes
JensWehner Aug 10, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,9 @@ jobs:

- name: Run pre-commit hooks
run: |
pre-commit install
pre-commit run --all-files
shell: micromamba-shell {0}

- name: Run mypy
run: mypy .
shell: micromamba-shell {0}
Comment on lines -37 to -39

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep mypy here to run it in our production environment rather than the incomplete pre-commit env?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the precommit mypy at the moment uses the local mypy version so it should use the full environment.


test:
runs-on: ubuntu-latest
needs:
Expand Down Expand Up @@ -81,3 +76,33 @@ jobs:
--pyargs skala
tests/
shell: micromamba-shell {0}

profiling:
name: "Profiling (Python=3.12 & PySCF=2.13.1)"
runs-on: ubuntu-latest
needs:
- lint
env:
OMP_NUM_THREADS: 4
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4

- name: Setup micromamba
uses: mamba-org/setup-micromamba@4b9113af4fba0e9e1124b252dd6497a419e7396d # v1
with:
environment-file: environment-cpu.yml
environment-name: skala
cache-environment: true
cache-downloads: true
create-args: >-
python=3.12
pyscf=2.13.1

- name: Install package in development mode
run: |
pip install -e . --no-deps
shell: micromamba-shell {0}

- name: Run profiling tests
run: pytest -v -m profiling tests/test_ao_screening_benchmark.py
shell: micromamba-shell {0}
15 changes: 15 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,18 @@ repos:
# Run the formatter.
- id: ruff-format
args: [--config, pyproject.toml]

- repo: https://github.com/srstevenson/nb-clean
rev: f745b986570ef12cfbe0cfe20a7e0271c328914f # frozen: 4.0.1
hooks:
- id: nb-clean

- repo: local
hooks:
- id: mypy
name: mypy
entry: mypy
language: system
args: [--config-file, pyproject.toml, --num-workers, "4", .]
pass_filenames: false
always_run: true
1 change: 1 addition & 0 deletions benchmarks/.gitignore

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would ignore these files, in this folder, I am not sure if they should be committed.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
results/
Loading
Loading