-
Notifications
You must be signed in to change notification settings - Fork 35
Improve Vxc Screening #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
766234a
implement screening
JensWehner 658c264
add docstrings
JensWehner eaf5d1c
add failing test for consistency
JensWehner a4dad08
add docstring and use dense eval
JensWehner 3fe4371
work on shell screening
JensWehner abee701
add nuclear gradient test
JensWehner 9428b67
add memory benchmark
JensWehner 8ad6f33
remove chunked case
JensWehner 0343e37
Apply suggestions from code review
JensWehner 9885e84
refactor tests
JensWehner a02c507
fix consistent screened response memory policy
JensWehner 0fc36be
refactor remove unsupported kinetic tensor features
JensWehner a425a10
refactor extract chunk evaluation helpers
JensWehner a6676cf
refactor centralize feature evaluation policy
JensWehner 5783c7a
refactor isolate feature mathematics
JensWehner d299389
refactor isolate ao autograd evaluation
JensWehner 683e350
refactor isolate screened feature evaluation
JensWehner 92ef053
refactor make screened grid cache explicit
JensWehner 60385d5
refactor separate xc integration from pyscf adapter
JensWehner 1307736
make functions private
JensWehner 428c393
Potential fix for pull request finding
JensWehner 5c0d8db
fix screening in the cpu case
JensWehner eec82b4
use pca grid decomposition
JensWehner cda8010
use enum and rework switch size patching
JensWehner 55fe903
fix enum properly
JensWehner f5fa1f2
make tests nicer
JensWehner 28cf7ef
make tests nicer
JensWehner 8a3b114
fix doc tests
JensWehner 740085d
clean notebooks
JensWehner c0a4a9d
commit notebooks for analysis
JensWehner 5114d3b
improve model chunking
JensWehner 26fa246
use analytic vjp for backpropagation of ml model outputs to density m…
JensWehner af88a1c
small optimisation
JensWehner 59b020b
use newer pyscf version in test
JensWehner 01a42db
pin versions
JensWehner 130bced
raise error bound
JensWehner 0308eb8
Make linear model simpler and add test
JensWehner c56a14a
require special skala grids
JensWehner eddd046
add pyscf 2.9 fixes
JensWehner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would ignore these files, in this folder, I am not sure if they should be committed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| results/ |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep mypy here to run it in our production environment rather than the incomplete pre-commit env?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the precommit mypy at the moment uses the local mypy version so it should use the full environment.