Fix out-of-bounds issue#1077
Open
apsonawane wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request strengthens the SegmentSum custom operator by adding runtime input validation for segment_ids to prevent invalid indexing behavior, and adds a regression test to ensure negative segment_ids are rejected.
Changes:
- Add validation in
segment_sumto reject negativesegment_idsand values outside the computed valid range. - Add a Python unit test that asserts an error is raised when
segment_idscontains a negative value.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
operators/math/segment_sum.cc |
Adds segment_ids validation (negative / range) before using values for output indexing. |
test/test_math_ops.py |
Adds a unit test ensuring negative segment_ids are rejected by the C++ operator. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds input validation to the
segment_sumoperator to ensure thatsegment_idsdoes not contain negative values and that all values are within the valid range. It also introduces a test to verify that negativesegment_idsare correctly rejected.Input validation improvements:
segment_sum(inoperators/math/segment_sum.cc) to return an error if any value insegment_idsis negative, including the first and last elements.segment_idsvalues are within the range[0, last_seg], returning an error if out of bounds.Testing:
test_segment_sum_cc_negative_segment_idsintest/test_math_ops.pyto verify that the operator raises an exception whensegment_idscontains negative values.