Fix out-of-bounds error#1075
Open
apsonawane wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request hardens the RaggedTensorToSparse custom operator by validating the row-splits (nested splits) input before it is used to compute output shapes and index buffers, preventing invalid shapes/indices and catching malformed inputs earlier.
Changes:
- Added a guard for an empty row-splits tensor (prevents
p_n_elements[-1]access when the input has 0 elements). - Added validation that row-splits starts at
0. - Added validation that row-splits is monotonic non-decreasing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds input validation to the
RaggedTensorToSparseoperator to ensure the row-splits tensor is well-formed. These checks help catch malformed inputs early and improve error messaging.Input validation improvements:
op_ragged_tensor.cc.