Skip to content

doc: list the benchmark host telemetry module in the source tree - #484

Merged
Pedro Henrique Penna (ppenna) merged 1 commit into
devfrom
doc-sync/project-structure-host-telemetry
Oct 11, 2026
Merged

Pedro Henrique Penna (ppenna) merged 1 commit into
devfrom
doc-sync/project-structure-host-telemetry

Conversation

@ppenna

Copy link
Copy Markdown
Contributor

Summary

PR #479 added scripts/nvx_tools/host_telemetry.py, but Project structure did not list it. It was the only tracked module in scripts/nvx_tools/ (apart from the empty __init__.py) missing from the source tree. This PR adds it to the directory tree and to the scripts/ overview, and links to the benchmark guide sections that describe what it records.

Changes

  • doc/project-structure.md, directory tree: adds host_telemetry.py as "Benchmark host provenance and Windows capture storage telemetry". Evidence: git ls-files scripts/nvx_tools and the module docstring in scripts/nvx_tools/host_telemetry.py.
  • doc/project-structure.md, scripts/ section: states that host_telemetry.py records the benchmark host's provenance and, on Windows, the storage activity during profiled snapshot captures. It links to Snapshot lifecycle profile and CI collection rather than repeating their detail. Evidence:
    • benchmark_host_provenance() in scripts/nvx_tools/benchmark.py calls host_telemetry.host_provenance().
    • create_storage_telemetry() returns None unless sys.platform == "win32".
    • benchmark.py creates the sampler only when snapshot_profile and a profile sink are set.
    • performance.py renders host_provenance_rows() in reports.

The design docs did not change. For reference, the pinned OpenVMM SHA is 7bf0ee28b826374a2d386067df0456b81bcae818.

Follow-ups (out of scope)

Validation

  • python -m unittest scripts.test_nvx_tools.CliTests scripts.test_performance.PerformanceTests: 117 tests passed (1 skipped).
  • A throwaway link checker, kept outside the repository, checked every relative link and anchor in doc/project-structure.md and in README.md, the file that links to it. It also confirmed that the changed file has one H1 and balanced code fences, and that doc/design.md links every chapter in doc/design/. Result: OK.
  • git diff --check: clean.
  • python scripts\nvx.py verify: passed. The submodule checkout matches the openvmm gitlink.
  • The diff changes only doc/project-structure.md, so CI classifies this PR as documentation-only.

PR #479 added scripts/nvx_tools/host_telemetry.py, which records benchmark host provenance and Windows capture storage telemetry, but the source tree did not list it.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ppenna Pedro Henrique Penna (ppenna) added the documentation Improvements or additions to documentation label Oct 11, 2026
Copilot AI balanced review requested due to automatic review settings October 11, 2026 16:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation accurately reflects the module’s implementation and uses valid section links.

0 open findings

What changed in this PR

Documents the benchmark host telemetry module in NVX’s project structure.

Changes:

  • Adds host_telemetry.py to the source tree.
  • Describes its provenance and Windows storage telemetry responsibilities with benchmark-guide links.
File Description
doc/​project-structure.md Documents the host telemetry module and related benchmark guidance.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ppenna
Pedro Henrique Penna (ppenna) merged commit 7ac73e5 into dev Oct 11, 2026
28 checks passed
@ppenna
Pedro Henrique Penna (ppenna) deleted the doc-sync/project-structure-host-telemetry branch October 11, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants