Repository navigation
doc: list the benchmark host telemetry module in the source tree - #484
Merged
Pedro Henrique Penna (ppenna) merged 1 commit intoOct 11, 2026
Merged
Conversation
PR #479 added scripts/nvx_tools/host_telemetry.py, which records benchmark host provenance and Windows capture storage telemetry, but the source tree did not list it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Pedro Henrique Penna (ppenna)
October 11, 2026 16:52
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation accurately reflects the module’s implementation and uses valid section links.
0 open findings
What changed in this PR
Documents the benchmark host telemetry module in NVX’s project structure.
Changes:
- Adds
host_telemetry.pyto the source tree. - Describes its provenance and Windows storage telemetry responsibilities with benchmark-guide links.
| File | Description |
|---|---|
doc/project-structure.md |
Documents the host telemetry module and related benchmark guidance. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Pedro Henrique Penna (ppenna)
deleted the
doc-sync/project-structure-host-telemetry
branch
October 11, 2026 17:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #479 added
scripts/nvx_tools/host_telemetry.py, but Project structure did not list it. It was the only tracked module inscripts/nvx_tools/(apart from the empty__init__.py) missing from the source tree. This PR adds it to the directory tree and to thescripts/overview, and links to the benchmark guide sections that describe what it records.Changes
doc/project-structure.md, directory tree: addshost_telemetry.pyas "Benchmark host provenance and Windows capture storage telemetry". Evidence:git ls-files scripts/nvx_toolsand the module docstring inscripts/nvx_tools/host_telemetry.py.doc/project-structure.md,scripts/section: states thathost_telemetry.pyrecords the benchmark host's provenance and, on Windows, the storage activity during profiled snapshot captures. It links to Snapshot lifecycle profile and CI collection rather than repeating their detail. Evidence:benchmark_host_provenance()inscripts/nvx_tools/benchmark.pycallshost_telemetry.host_provenance().create_storage_telemetry()returnsNoneunlesssys.platform == "win32".benchmark.pycreates the sampler only whensnapshot_profileand a profile sink are set.performance.pyrendershost_provenance_rows()in reports.The design docs did not change. For reference, the pinned OpenVMM SHA is
7bf0ee28b826374a2d386067df0456b81bcae818.Follow-ups (out of scope)
unittest_results.txtis tracked at the repository root. It holds a 50 KB unittest log from the initial commit and looks like an accidentally committed artifact. This PR doesn't document it. A maintainer should decide whether to delete it, which is a non-documentation change.scripts/setup/README.mdis documentation outsidedoc/. Moving it intodoc/means updating links indoc/ci.mdanddoc/setup.md, which open PRs filesystem: share single host files without their directories #475, Adopt bind-once microVM image slots #406, and test-microvm: pause and resume a microVM through OpenVMM state control #405 also change, and a path inscripts/test_nvx_tools.py, so I left it for a later run.Validation
python -m unittest scripts.test_nvx_tools.CliTests scripts.test_performance.PerformanceTests: 117 tests passed (1 skipped).doc/project-structure.mdand inREADME.md, the file that links to it. It also confirmed that the changed file has one H1 and balanced code fences, and thatdoc/design.mdlinks every chapter indoc/design/. Result: OK.git diff --check: clean.python scripts\nvx.py verify: passed. The submodule checkout matches theopenvmmgitlink.doc/project-structure.md, so CI classifies this PR as documentation-only.