Bump immutable from 3.8.3 to 4.3.9 - #192
Merged
Merged
Conversation
Bump the root immutable resolution to 4.3.9. immutable v4 changed Map#toArray() to return [key, value] entry pairs instead of values, which silently breaks relay-compiler v12 codegen. Patch both relay-compiler@12 and @ardatan/relay-compiler@12 to use valueSeq().toArray() in CompilerContext.documents() and CodegenRunner, matching microsoft/graphitation PR #720. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
celiac747
force-pushed
the
celiac747-bump-immutable-4-3-9
branch
from
September 1, 2026 09:37
dfa5f45 to
5c889c4
Compare
sergey-stoyan
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the root
immutableresolution from3.8.3to4.3.9.immutableis not a direct dependency of any package — it is a transitive dependency ofrelay-compiler@12/@ardatan/relay-compiler@12(used bypackages/nova-graphql-compiler), pinned through the rootresolutionsblock.Why the resolution bump alone isn't enough
immutable v4 changed
Map#toArray()to return[key, value]entry pairs instead of values, which silently breaks relay-compiler v12 codegen (it produces malformed/empty schema input rather than erroring). To keep relay-compiler v12 working under immutable v4, both copies are patched to usevalueSeq().toArray():lib/core/CompilerContext.js—documents():this._documents.toArray()→this._documents.valueSeq().toArray()lib/codegen/CodegenRunner.js—baseDocuments.toArray()→baseDocuments.valueSeq().toArray()This mirrors the fix in microsoft/graphitation PR #720. Patches are applied via Yarn berry's native
patch:protocol (.yarn/patches/*.patch+resolutionswiring).Changes
package.json:resolutions.immutable^3.8.3→^4.3.9, pluspatch:resolution entries forrelay-compiler@npm:^12.0.0and@ardatan/relay-compiler@npm:12.0.0.yarn.lock:immutablenow resolves to4.3.9(no3.8.3entry remains)..yarn/patches/relay-compiler-npm-12.0.0-*.patchand.yarn/patches/@ardatan-relay-compiler-npm-12.0.0-*.patch.No beachball changefile —
immutableis a resolution, not a published dependency of these packages.Validation
yarn install --immutablepasses.CompilerContext.jsandCodegenRunner.jsfor bothrelay-compilerand@ardatan/relay-compilercontainvalueSeq().toArray().yarn lage build✓ andyarn lage test✓ (all green).nova-graphql-compilerrelay codegen test passes end-to-end (generatesExample_feedbackFragment.graphql.ts), confirming relay-compiler v12 works correctly under immutable v4.Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com