Repository navigation
Fix IsolationSession bundle BinSkim failure - #1456
Merged
Dan Legg (danlegg) merged 1 commit intoOct 9, 2026
Merged
Conversation
Remove node-pty PDBs from the staged test bundle so BinSkim does not consume upstream S_COMPILE3 records. Runtime binaries remain intact. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1d43372e-f942-4bb7-a358-48f9218c2332
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The targeted removal occurs after staging and leaves the packaged runtime binaries intact.
0 open findings
What changed in this PR
Prevents BinSkim BA2007 failures caused by third-party node-pty debug symbols in the IsolationSession test bundle.
Changes:
- Removes only
node-ptyPDB files after staging. - Preserves all runtime binaries and reports the removal count.
| File | Description |
|---|---|
.azure-pipelines/templates/IsolationSession.TestBundle.Build.Job.yml |
Excludes staged node-pty PDBs from BinSkim analysis. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Branden Bonaby (bbonaby)
approved these changes
Oct 9, 2026
Dan Legg (danlegg)
deleted the
user/dalegg/fix-isosession-bundle-binskim
branch
October 9, 2026 18:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove node-pty PDBs from the staged test bundle so BinSkim does not consume upstream S_COMPILE3 records. Runtime binaries remain intact.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
📖 Description
🔗 References
🔍 Validation
✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see pull request builds)📋 Issue Type
GitHub Actions runs the PR validation build automatically. The ADO pipeline
(
MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHubActions build; it runs on merge to
main, and Microsoft reviewers with write access can trigger iton a PR with
/azp run. See pull request builds.If the
dependency-feed-checkcheck fails on a new dependency, the crate must be added tothe feed before the PR can pass. See pull request builds
for the steps.
Microsoft Reviewers: Open in CodeFlow