Repository navigation
Conversation
Align SDK and sample versions, refresh dependencies, and clean generated output before building and packing the SDK packages. Move CI to Node 22/24 with npm 11.21.2, preserve test/debug Node flags, and fix canvas module initialization with focused load-order regressions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4e3089fe-4e04-4b42-84cc-e354789c2143
huntj88
marked this pull request as ready for review
November 13, 2026 20:51
Pradeep Anantharaman (pradeepananth)
self-requested a review
November 13, 2026 21:07
Pradeep Anantharaman (pradeepananth)
approved these changes
Nov 13, 2026
There was a problem hiding this comment.
🟡 Changes recommended
The 3D-model sample’s mock Teams context omits the dialogParameters field required by Teams JS 2.59.0, causing a type-checking error.
1 open issue
What changed in this PR
Prepares coordinated 1.4.3 SDK releases and updates the repository’s build, packaging, and Node tooling.
Changes:
- Aligns stable and preview versions, refreshes dependencies, and restores the tracked-manifest version updater.
- Adds clean builds, prepack rebuilds, and publication allowlists; raises toolchain requirements and updates CI to Node 22/24.
- Fixes canvas module initialization, adds isolated loading regressions, and updates sample typings.
| File | Description |
|---|---|
samples/typescript/31.live-canvas-tests/package.json |
Updates SDK references and Vite. |
samples/typescript/21.react-media-template/src/teams-js-hooks/useTeamsContext.ts |
Adds the required fake-context field. |
samples/typescript/21.react-media-template/src/teams-js-hooks/useSharingStatus.ts |
Uses compatible interval-handle typing. |
samples/typescript/21.react-media-template/package.json |
Refreshes SDK, routing, and build dependencies. |
samples/typescript/08.3d-model/package.json |
Updates SDK, Babylon.js, and tooling dependencies. |
samples/typescript/07.countdown-timer/package.json |
Aligns SDK versions and refreshes dependencies. |
samples/typescript/06.presence-avatars/package.json |
Aligns SDK versions and refreshes dependencies. |
samples/typescript/05.dice-roller-turbo/package.json |
Updates SDK references and Vite. |
samples/typescript/04.live-share-react/package.json |
Updates SDK, routing, and tooling dependencies. |
samples/typescript/03.live-canvas-demo/package.json |
Updates SDK references and Vite. |
samples/typescript/01.dice-roller/package.json |
Updates the core SDK reference and Vite. |
samples/javascript/23.react-live-canvas/package.json |
Updates SDK, routing, and tooling dependencies. |
samples/javascript/22.react-agile-poker/package.json |
Updates SDK, routing, and tooling dependencies. |
samples/javascript/21.react-media-template/package.json |
Refreshes SDK, routing, and build dependencies. |
samples/javascript/05.dice-roller-turbo/package.json |
Updates SDK references and Vite. |
samples/javascript/04.live-share-react/package.json |
Updates SDK, routing, and tooling dependencies. |
samples/javascript/03.live-canvas-demo/package.json |
Updates SDK references and Vite. |
samples/javascript/02.react-video/package.json |
Refreshes SDK, browser-test, and build dependencies. |
samples/javascript/01.dice-roller/package.json |
Updates the core SDK reference and Vite. |
README.md |
Documents minimum Node and npm requirements. |
packages/live-share/package.json |
Updates release, packaging, build, and test metadata. |
packages/live-share-turbo/package.json |
Updates preview release metadata and core references. |
packages/live-share-react/package.json |
Updates preview release metadata and SDK dependencies. |
packages/live-share-media/package.json |
Updates release metadata, packaging, and test scripts. |
packages/live-share-canvas/src/test/ModuleLoading.spec.ts |
Adds two isolated module-loading regressions. |
packages/live-share-canvas/src/core/internals/utils.ts |
Replaces barrel imports with direct module imports. |
packages/live-share-canvas/package.json |
Updates packaging and declares the UUID dependency. |
packages/live-share-acs/package.json |
Updates preview release metadata and build/test scripts. |
package.json |
Declares toolchain requirements and dependency overrides. |
internal/build-tools/update-versions.js |
Updates tracked SDK manifests and internal references. |
.github/workflows/live-share-test-packages.yaml |
Tests on Node 22/24 with the required npm version. |
.github/workflows/live-share-build-samples.yaml |
Builds on Node 22/24 with the required npm version. |
Review effort: Max
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4e3089fe-4e04-4b42-84cc-e354789c2143
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation