fix: close streaming responses before retrying#565
Merged
baywet merged 2 commits intoJun 7, 2026
Conversation
|
baywet
approved these changes
Jun 5, 2026
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Please make sure you sign the CLA (see the bot message)
Contributor
Author
|
sorry for the delay here, just making sure I have the right approvals to sign the CLA on behalf of my company, because I made this change as part of work |
Member
|
No worries, we're working on a deployment pipeline migration anyway. |
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Author
|
I was advised by my employer to sign on my own behalf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR closes a response in RetryHandler's retry loop before response gets reassigned by the retry loop. This allows the connection that produced the response to get released back to its connection pool to serve another request.
Related Issue
Fixes #564
Testing Instructions
Added test_retried_responses_are_closed to packages/http/httpx/tests/middleware_tests/test_retry_handler.py to verify retried responses are closed (so their connections are released back to the pool). It drives the real RetryHandler with a MockTransport returning 429, 429, 200, and asserts the two retried responses report is_closed while the returned 200 stays open. Runs in the existing suite via pytest.