Skip to content

ci: support variant-prefixed devcontainer Go tags #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dlevy-msft-sql wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

ci: support variant-prefixed devcontainer Go tags #778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/devcontainer-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,10 @@ jobs:
GOMOD_VERSION=$(grep '^go ' go.mod | awk '{print $2}')
GOMOD_MAJOR_MINOR=$(echo "$GOMOD_VERSION" | grep -oE '^[0-9]+\.[0-9]+')

# Extract the Go version from the Dockerfile base image tag
DOCKERFILE_TAG=$(grep -oP 'devcontainers/go:\K[0-9]+\.[0-9]+' .devcontainer/Dockerfile)
# Extract the Go version from the Dockerfile base image tag.
# Accept both the legacy form (go:1.26-bookworm) and the variant-prefixed
# form (go:2-1.26-bookworm) published on mcr.microsoft.com.
DOCKERFILE_TAG=$(grep -oP 'devcontainers/go:(?:[0-9]+-)?\K[0-9]+\.[0-9]+' .devcontainer/Dockerfile)

echo "go.mod requires: go ${GOMOD_VERSION} (major.minor: ${GOMOD_MAJOR_MINOR})"
echo "Dockerfile base image: go:${DOCKERFILE_TAG}"
Expand Down