Fix macOS/iOS test GoogleTest includes - #1518
Open
bmehta001 wants to merge 1 commit into
Open
Conversation
Attach GoogleTest include paths to test targets and use the canonical SQLite3 target while retaining compatibility with older CMake releases. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- Attach GoogleTest/GoogleMock include paths to FuncTests and UnitTests through a target-level interface configuration.\n- Fail at configure time with a clear message when the GoogleTest submodule is unavailable.\n- Use canonical CMake 4.3+ SQLite3::SQLite3 targets, with compatibility aliases for older CMake versions.\n\nThis is intentionally focused on the macOS/iOS test build and does not modify the timestamp changes in #1516.\n\n## Validation\n\n- CMake 4.4 configure succeeds with both test targets enabled.\n- Functional test sources, including APITest.cpp, compile with the propagated GoogleTest headers.\n- Full Windows link was blocked by the existing legacy out/gtest/gtest.lib path convention.