Repository navigation
Add containerd patch to handle dmverity referrers - #99
Open
Dallas Delaney (dallasd1) wants to merge 1 commit into
Open
Dallas Delaney (dallasd1) wants to merge 1 commit into
Dallas Delaney (dallasd1) wants to merge 1 commit into
Conversation
Dallas Delaney (dallasd1)
deployed
to
development
October 10, 2026 00:27 — with
GitHub Actions
Active
Copilot started reviewing on behalf of
Dallas Delaney (dallasd1)
October 10, 2026 00:32
View session
Open
2 of 16 tasks
There was a problem hiding this comment.
🟡 Changes recommended
The security-critical referrer discovery and validation pipeline lacks focused automated tests.
1 open finding
What changed in this PR
Adds opt-in signed dm-verity referrer support to containerd’s EROFS snapshotter and CRI integration.
Changes:
- Discovers, caches, validates, and materializes signed dm-verity artifacts.
- Separates signed and unsigned snapshot identities and supports offline reuse.
- Enables the patch in the containerd2 RPM.
| File | Description |
|---|---|
acl/SPECS/containerd2/erofs-signed-dmverity.patch |
Implements signed referrer handling across transfer, CRI, unpack, EROFS, and dm-verity paths. |
acl/SPECS/containerd2/containerd2.spec |
Applies the patch and increments the package release. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1148
to
+1154
| +func fetchSignatures( | ||
| + ctx context.Context, | ||
| + fetcher remotes.Fetcher, | ||
| + store content.Store, | ||
| + subject ocispec.Descriptor, | ||
| + imageLayers map[string]struct{}, | ||
| +) (*dmverityBundle, bool, error) { |
Dallas Delaney (dallasd1)
marked this pull request as ready for review
October 10, 2026 01:00
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Patch containerd to be able to discover dmverity OCI referrers if new config option
enable_dmverity_referrersis present. This patch represents changes to support this in the CRI, transfer service, unpacker, differ, snapshotter, and mount paths.Tests have intentionally been stripped from this patch to reduce its size.
Additions
application/vnd.containerd.erofs.dmverity.v1for an image manifest and stores its per-layer EROFS metadata, Merkle tree, and detached PKCS#7 root-hash signature in the content store.enable_dmverity_referrersindicates the snapshotter is capable of referrer fetching. The snapshotter will materialize the published artifacts alongside the original layer tar data.Limitations and Prerequisites
enable_dmverity_referrersenabled in the config, a compatible dm-verity mode, and the required kernel support.PR that will invoke this behavior when IPE is enabled: #98
Change Log
Type of Change
Does this affect the image build?
Associated Issues
Test Methodology
Merge Checklist
All applicable boxes should be checked before merging