Skip to content

Support per-file relative instruction references - #244

Merged
Brian Krabach (bkrabach) merged 1 commit into
mainfrom
fix/nested-instruction-mentions
Sep 25, 2026
Merged

Brian Krabach (bkrabach) merged 1 commit into
mainfrom
fix/nested-instruction-mentions

Conversation

@bkrabach

@bkrabach Brian Krabach (bkrabach) commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Expose Foundation's optional per-call relative-resolution capability in the app mention resolver. Nested explicit @./tasks.md references can then resolve beside their source without changing the session workspace or the roots used by user/project/bundle shortcuts. Existing traversal rejection and omitted .md handling remain intact.

Companion to microsoft/amplifier-foundation#414. This adapter works with older Foundation, but the recursive fix requires that upstream change plus a dependency refresh; this PR does not change the current lockfile.

Validation: 36 instruction, runtime-mention and host-resume checks passed with the patched Foundation installed explicitly in an isolated virtual environment. This includes frozen-snapshot host guards and runtime input/delegation boundaries. With the original locked Foundation, the focused adapter/prompt checks passed (7 passed, 8 runtime tests skipped before installing loop dependencies). An offline fixture verifies synthetic global/project nested instruction delivery once per prompt, two bundle namespaces, refreshed factories, edits/removal and no workspace fallback. It does not access personal files or make model requests. Acceptance is generic instruction/reference delivery; no journal-specific behavior is introduced or required.

@bkrabach
Brian Krabach (bkrabach) marked this pull request as ready for review September 25, 2026 13:01
@bkrabach
Brian Krabach (bkrabach) merged commit f50b92b into main Sep 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant