Preserve saved endpoints during provider preflight - #203
Merged
Brian Krabach (bkrabach) merged 1 commit intoSep 24, 2026
Merged
Conversation
This was referenced Sep 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provider metadata discovery discarded saved endpoints, so vLLM's public constructor failed before Unified could materialize any provider. Pass the exact configured instance's endpoint to constructors that declare
base_url, while keeping metadata config empty and excluding saved API/token fields. Model-list/test probes receive the same materialized endpoint.Bundle preflight now collects allowlisted module/instance failures and commits root/nested provider changes only after every instance passes. Failed preflight leaves priorities, role preferences, accounts, and both plans unchanged. Errors identify schema versus configuration failure without raw exceptions or configuration values; feedback retains reason counts without account identities.
Partially addresses #182. Missing required credentials on an enabled provider still stop preparation. Full per-provider isolation needs a supported per-instance mount outcome plus routing rules that propagate unavailable-provider failures instead of silently selecting another account. The concrete boundaries are documented in
docs/validation/provider-preflight.md; this PR introduces no loader patches, placeholders, or changed fallback policy.Validation: the credential-free before/after reproduction failed when the saved endpoint was discarded and passed with the exact endpoint after this change, without network/model calls. 186 focused Python checks passed, including isolated probe subprocesses, setup, provider selection/lifecycle, host resume, bundle/shared-runtime preparation, and diagnostics; the updated feedback diagnostics suite also passed 9/9. Tests cover distinct account endpoints, missing endpoints/secrets, nested atomicity, cancellation, and sanitized errors. No Spark access, live provider request, CLI installation, merge, or publication was performed.