Repository navigation
fix: make auto-continuation settings-only - #47
Merged
Merged
Conversation
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
auto_continueremains an optional settings-only override; omitting it keeps continuation enabled, and explicitfalse(including legacy string values) remains honored.This is the vLLM part of the settings-only continuation release; the CLI override-preservation fix is in amplifier-app-cli#366. It does not change input truncation, timeouts, or impose a completion deadline. No breaking changes intended.
Why
The provider setup wizard should not ask about this optional advanced setting. Removing its metadata prompt keeps setup focused while preserving current defaults and explicit settings. The CLI preservation fix ensures reconfiguration does not discard the override.
How to verify
uv run pytest -q -m "not live": 369 passed, 1 live test deselected.