feat(loop): execute marked native tool batches sequentially - #66
Open
Brian Krabach (bkrabach) wants to merge 3 commits into
Open
Brian Krabach (bkrabach) wants to merge 3 commits into
Brian Krabach (bkrabach) wants to merge 3 commits into
Conversation
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Fresh internal goal judge, evaluator, and summary calls now request high reasoning effort and explicitly disable extended thinking without inheriting incompatible thinking budget or display settings. Main conversational requests remain unchanged. Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Collaborator
Author
|
Review-readiness evidence (not a GitHub formal approval):
No CODEOWNERS or clear public prior reviewer assignment was found, and no reviewer is currently requested. Please use the repository's normal human approval gate. |
Brian Krabach (bkrabach)
marked this pull request as ready for review
September 30, 2026 12:10
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
_amplifier_execution_mode=sequentialexecutes a native tool batch in provider response order.start → finish, thenstart → finish.is_error: true, including thecomputer-tagged result, and the provider continues to the next real request, which returned HTTP 200.effort="high"andextended_thinking=false.Why
Native computer actions can share mutable UI state, so marked batches must run sequentially while ordinary unmarked batches retain their existing parallel behavior. Internal evaluator calls need compatible request settings when the global configuration uses
xhigh; otherwise tool requests can inherit incompatible thinking settings. The utility-only override avoids that conflict without changing the main conversation.Verification
8ce68dd8e2480f2804365ac9e31ef9c44e308c88and the published, SHA-256-verified Core 2.0.1 wheel.start → finish / start → finishexecution.Qualification status
1dfremains separate in existing PR #130.Breaking changes
No intended breaking changes. Sequential execution is opt-in through the provider marker; unmarked tool batches retain their parallel behavior. Utility-only evaluator settings do not change main-conversation role or model selection.
Optional managed-context handoff
context.final_request_record/context.signed_replaycapability handoff. The loop snapshots the exact final request only after all overlays, budget fitting, measured-context transaction commits, and cancellation checks, and binds the admitted assistant response only after canonical context admission.Additional scoped verification
4d8e4106c9f30e2f7dea53414ad8adb72cca345is a direct child of the reviewed PR head8ce68dd8e2480f2804365ac9e31ef9c44e308c88; no rebase, squash, or force-push was used.