fix(loop): preserve unavailable request-budget compatibility - #55
Merged
Brian Krabach (bkrabach) merged 2 commits intoSep 15, 2026
Merged
Conversation
Initial literal None from optional request_budget preserves the ordinary dispatch path. Later None or a vanished callable after a concrete rebuild/output decision raises ContextLengthError locally. Adds forced-finalization regressions that prove no final SDK dispatch and tool-turn closure. Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
request_budgetresult ofNoneas unavailable, preserving the established normal-dispatch path.None; do not treat uncertainty as a fit or send an unchecked SDK request.Why
A provider can lack a trustworthy cold budget before it has calibration data. This consumer must keep that compatibility case distinct from a later loss of a capability already used to enforce a concrete budget. The latter remains fail-closed, without dropping input.
Compatibility
request_budget, and an initial unavailable budget, keep normal dispatch behavior.Verification
Breaking changes
None. The only changed failure behavior is intentional: a budget capability that becomes unavailable after returning a concrete decision fails closed before dispatch.
Generated with Amplifier