fix: retain active persisted reminders across requests and resume - #51
Merged
Merged
Conversation
Port reviewed request-retention assembly from candidate ea96aa6, adding canonical admission-metadata resume deduplication, compatibility warning fallback, and focused retention tests. Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
context.request_retentioncapability for normal, continuation, and bounded-finalization request assembly.Persist mode remains the default and message roles are unchanged. Explicit legacy tail mode is unchanged. Whole-body deduplication is not per-contributor deduplication. This PR uses the compatible Context capability implementation merged in microsoft/amplifier-module-context-simple#40.
Why
The active persisted reminder needs to survive request-view compaction and resume without repeatedly adding an unchanged full reminder body.
Verification
Limits
This is not a claim of a complete live-evaluation matrix, hard token ceiling, 1M-window behavior, or general-quality improvement. A live causal A/B remains unproven. Anthropic strict bare-JSON corroboration remains failing because otherwise-correct output used a Markdown fence.
Breaking changes
None. The retention capability is optional; older contexts retain legacy assembly with a warning.