fix: complete full-validator repair and refresh diagram - #119
Merged
Merged
Conversation
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Require CI_VALIDATE_RECIPE when cached Foundation validator discovery is not exactly one readable recipe, before virtual-environment creation or dependency installation. Document and test explicit selection and fail-closed ambiguity. Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Collaborator
Author
|
Dependency update: Foundation PR #395 carries the v3.16.1 mode-path and diagram-composition repair. Local candidate |
Brian Krabach (bkrabach)
marked this pull request as ready for review
September 19, 2026 02:22
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publishes the tested conflict-resolution merge commit
89cb770, integrating this validator-launcher repair with currentmain. The repair keeps full validation genuinely full and fail-closed: it uses the normal Foundation dependency closure with a Foundation override, selects exactly one explicit or cached validator recipe, preserves the caller's Amplifier identity, and cleans up a newly owned external environment on either outcome.The prerequisite has landed: Foundation #395 merged as
f13d081, whose post-merge CI run passed all six jobs.Scope / guardrails
The delta from current
mainis limited to eight paths:AGENTS.md,CONTRIBUTING.md,.github/PULL_REQUEST_TEMPLATE.md,scripts/validate-full.sh,tests/test_validate_full.py,tests/test_validate_full_launcher.py,bundle.dot, andbundle.png.The merge preserves current
main; runtime README, skills, locks, agents, hooks, modes, tools, and server behavior are not changed by this PR. It introduces no runtime CI seam change. The wrapper still keeps the environment outside the inspected target, refuses pre-existing explicitly requested locations, retains the no-ERROR-waiver rule, and performs cleanup on success and failure.Verification
tool-context-intelligence-query: 195 passed; transcript module: 34 passed.tests/: 898 passed, including 20 launcher tests.ruff check+ruff format --checkclean — locked Ruff 0.15.11, 180 files.pyrightclean — 0 errors, 0 warnings.scripts/validate-full.shused the merged Foundation validator revision and reportedenv_check.validation_mode: full,build_check.build_tested: true, andbuild_check.build_success: true;quality_classification.quality_level: polishwith 0 critical and 0 ERROR findings.final_report: PASS WITH SUGGESTIONS. No ERROR waiver, filter, or suppression was used.Real evidence on seams (not mock-only)
Docs & diagrams
bundle.dot/bundle.pngwere checked by the full validator: noBUNDLE_DOT_STALE; canonical regeneration left both artifacts byte-identical with all 14 composition relationships preserved.AGENTS.md,CONTRIBUTING.md, and this template record the durable full-validation/operator guidance.Notes / follow-ups